Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mvp language server #8515

Merged
merged 25 commits into from
Dec 7, 2020
Merged

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Nov 27, 2020

Resolves #8400

This is still a not quite ready for merging PR, but it has gotten far enough to get wider review/thoughts input. Things I know I still need to do:

  • Integration Test Infrastructure
  • lots moar unit tests we can tackle this as part of the follow up
  • integrate hover
  • figure out remote module resolution
  • create a list of other features we need to add (Deno language server to-do list #8643)

@kitsonk
Copy link
Contributor Author

kitsonk commented Nov 27, 2020

I will add more detailed instructions later, but if you want to try it out, you need to build this branch, and have it available in your path as deno and use this branch of vscode_deno: denoland/vscode_deno#263. When you have the vscode_deno project checked out and installed and built (npm i && npm run compile && npm i) open in vscode and go to the debug Run panel and choose the Launch Client option and it will open up a window with the extension enabled.

@kitsonk kitsonk changed the title [WIP] feat: add language server feat: add mvp language server Dec 4, 2020
cli/Cargo.toml Outdated Show resolved Hide resolved
cli/Cargo.toml Outdated Show resolved Hide resolved
cli/lsp/analysis.rs Outdated Show resolved Hide resolved
cli/lsp/analysis.rs Show resolved Hide resolved
cli/lsp/analysis.rs Show resolved Hide resolved
cli/lsp/state.rs Outdated Show resolved Hide resolved
cli/lsp/task_pool.rs Outdated Show resolved Hide resolved
cli/lsp/text.rs Show resolved Hide resolved
cli/lsp/tsc.rs Show resolved Hide resolved
cli/lsp/tsc.rs Outdated Show resolved Hide resolved
@ry
Copy link
Member

ry commented Dec 4, 2020

New version of vscode-deno has been published at https://marketplace.visualstudio.com/items?itemName=denoland.vscode-deno-canary

ref denoland/vscode_deno#272

cli/lsp/task_pool.rs Outdated Show resolved Hide resolved
cli/lsp/text.rs Show resolved Hide resolved
cli/lsp/tsc.rs Outdated Show resolved Hide resolved
cli/lsp/tsc.rs Outdated Show resolved Hide resolved
@ry
Copy link
Member

ry commented Dec 4, 2020

I'm trying to use the published "Deno (Canary)" extension and seeing double messages. I have the original deno extension disabled. Any idea what's happening here?

Screen Shot 2020-12-04 at 11 20 47 AM

cli/lsp/diagnostics.rs Outdated Show resolved Hide resolved
@kitsonk
Copy link
Contributor Author

kitsonk commented Dec 4, 2020

I'm trying to use the published "Deno (Canary)" extension and seeing double messages. I have the original deno extension disabled. Any idea what's happening here?

Hmmm... that is strange. You can see the source is both ts and deno-lint, it would seem that the extension isn't suppressing the messages from TS, but thinks it is enabled. 😖

@kitsonk kitsonk closed this Dec 4, 2020
@kitsonk kitsonk reopened this Dec 4, 2020
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 massive feature

Copy link
Member

@ry ry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@kitsonk kitsonk merged commit 301d3e4 into denoland:master Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deno lsp
5 participants