-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: new typescript WPT runner #9269
Conversation
@kitsonk @bartlomieju @ry @kt3k @piscisaureus @bnoordhuis Please try this out locally: ./tools/wpt.ts setup
./tools/wpt.ts run --quiet I want to make sure it actually works for everyone before proceeding. |
This comment has been minimized.
This comment has been minimized.
|
||
### FAQ | ||
|
||
#### Upgrading the wpt submodule: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this section necessary? test_util/wpt
in .gitmodules
seems still pointing to the upstream.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably not, but I think it doesn't hurt to be clear about it.
The instruction and the error messages look great. I hope this addresses the issues concerning new contributors. |
Nit: if I haven't compiled Deno yet, I get an error which is difficult to understand:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works for me.
@ry Addressed this by automatically invoking |
This is a new WPT runner, written in TypeScript. It is a lot more advanced than the integration test for WPT we had previously.
/etc/hosts
.TODO:
wpt.ts run -- encoding
wpt.ts setup
to auto configure /etc/hosts file and check correct python versionwpt.ts update
to update theexpectation.json
based on currently passing testswpt.ts update