feat(node): add child_process.execSync()

Refs: denoland#2631
cjihrig · Sep 22, 2022 · 4566ad5 · 4566ad5
1 parent c0aaa17
commit 4566ad5
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 3 deletions.
diff --git a/node/_tools/config.json b/node/_tools/config.json
@@ -711,7 +711,6 @@
       "test-dns-resolveany.js",
       "test-fs-access.js",
       "test-fs-readdir-stack-overflow.js",
-      "test-fs-rm.js",
       "test-fs-watchfile.js",
       "test-fs-write-file-invalid-path.js",
       "test-fs-write-file-sync.js",

diff --git a/node/child_process.ts b/node/child_process.ts
@@ -16,9 +16,12 @@ import {
   ERR_CHILD_PROCESS_STDIO_MAXBUFFER,
   ERR_INVALID_ARG_VALUE,
   ERR_OUT_OF_RANGE,
+  genericNodeError,
 } from "./internal/errors.ts";
 import {
+  ArrayPrototypeJoin,
   ArrayPrototypePush,
+  ObjectAssign,
   StringPrototypeSlice,
 } from "./internal/primordials.mjs";
 import { getSystemErrorName } from "./util.ts";
@@ -564,8 +567,39 @@ export function execFile(
   return child;
 }
 
-export function execSync() {
-  throw new Error("execSync is currently not supported");
+function checkExecSyncError(ret, args, cmd) {
+  let err;
+  if (ret.error) {
+    err = ret.error;
+    ObjectAssign(err, ret);
+  } else if (ret.status !== 0) {
+    let msg = "Command failed: ";
+    msg += cmd || ArrayPrototypeJoin(args, " ");
+    if (ret.stderr && ret.stderr.length > 0) {
+      msg += `\n${ret.stderr.toString()}`;
+    }
+    err = genericNodeError(msg, ret);
+  }
+  return err;
+}
+
+export function execSync(command, options) {
+  const opts = normalizeExecArgs(command, options, null);
+  const inheritStderr = !opts.options.stdio;
+
+  const ret = spawnSync(opts.file, opts.options);
+
+  if (inheritStderr && ret.stderr) {
+    process.stderr.write(ret.stderr);
+  }
+
+  const err = checkExecSyncError(ret, opts.args, command);
+
+  if (err) {
+    throw err;
+  }
+
+  return ret.stdout;
 }
 
 export default {