Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

io/streams.ts broken with lib.dom #871

Closed
lucacasonato opened this issue Apr 23, 2021 · 0 comments · Fixed by #891
Closed

io/streams.ts broken with lib.dom #871

lucacasonato opened this issue Apr 23, 2021 · 0 comments · Fixed by #891
Assignees
@kitsonk
Labels
bug Something isn't working

Comments

@lucacasonato
Copy link
Member 

error: TS2322 [ERROR]: Type 'string' is not assignable to type 'undefined'.
    type: "bytes",
    ~~~~
    at https://deno.land/std@0.95.0/io/streams.ts:205:5

cc @kitsonk

To reproduce, import io/streams.ts with lib.dom and lib.deno.ns in your tsconfig libs.
@lucacasonato lucacasonato added the bug Something isn't working label Apr 23, 2021
@kitsonk kitsonk self-assigned this Apr 24, 2021
kitsonk added a commit to kitsonk/deno_std that referenced this issue Apr 30, 2021
@kitsonk
fix(io/streams): don't use a byte ReadableStream
f1859a5 
Fixes: denoland#871
kitsonk added a commit to kitsonk/deno_std that referenced this issue Apr 30, 2021
@kitsonk
fix(io/streams): don't use a byte ReadableStream
81771da 
Fixes: denoland#871
@kitsonk kitsonk mentioned this issue Apr 30, 2021
Merged
kitsonk added a commit that referenced this issue May 2, 2021
@kitsonk @kt3k
fix(io/streams): don't use a byte ReadableStream (#891)
e78300c 
Fixes: #871

Co-authored-by: Yoshiya Hinosawa <stibium121@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kitsonk kitsonk

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(io/streams): don't use a byte ReadableStream kitsonk/deno_std
2 participants
@kitsonk @lucacasonato