Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(node): throw permisison error instead of unknown error #3133

Merged
merged 4 commits into from
Jan 30, 2023
Merged

fix(node): throw permisison error instead of unknown error #3133

merged 4 commits into from
Jan 30, 2023

Conversation

lino-levan
Copy link
Contributor

Closes #1396

@lino-levan lino-levan requested a review from kt3k as a code owner January 25, 2023 00:27
@kt3k
Copy link
Member

kt3k commented Jan 26, 2023

Looks reasonable changes. Can you add test cases to exercise those cases?

kt3k
kt3k approved these changes Jan 30, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kt3k kt3k merged commit 634f96c into denoland:main Jan 30, 2023
bartlomieju pushed a commit to bartlomieju/deno_std that referenced this pull request Feb 1, 2023
@lino-levan @bartlomieju
fix(node): throw permisison error instead of unknown error (denoland#…
d3b6f28 
…3133)
@lino-levan lino-levan deleted the fix-unknown-error branch March 14, 2023 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

node/dns.ts crashes with UNKNOWN error if --allow-net permission is missing
2 participants
@lino-levan @kt3k