-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(prettier): output to stdout instead of write file by default unless specified --write flag #332
Conversation
I think this feature is nice to have. We need to be careful with the timing of merging of this PR because this will break |
@ry it's ready for review. |
@axetroy It LGTM. I'm a bit concerned that this will break "deno fmt" (we should be using a tagged link to std/prettier and not master link). |
@ry yes. it will break the And I think about again that when should be output to stdout? When should be output to stdout?
formatted code should always be printed to stdout even |
…into prettier_print
@ry I think it's now safe to merge this PR. I checked
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@axetroy Thank you for updating! LGTM
waiting for #424 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…ess specified --write flag (denoland/std#332) Original: denoland/std@434007b
Why?
prettier cli
deno fmt example.ts
to print formatted code in stdoutbefore: without
--write
after: with
--write
This PR bring BREAKING CHANGE:
Prettier
now output to stdout instead of overwriting the file by default. unless specified--write
flagWhen should be output to stdout?
--write
/--check
flagsource content
not equal toformatted content