feat(collections): switch functions to take iterables when possible #3401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kt3k
reviewed
May 30, 2023
collections/permutations.ts
Outdated
| const ret: T[][] = []; | ||
| const k = inputArray.length; | ||
|
|
||
| // Heap's Algorithm |
There was a problem hiding this comment.
Very minor point, but I think this comment shouldn't be moved here as this seems referring to the algorithm in the below while loop
|
@kt3k I've moved the comment back down to where it was originally. |
kt3k
approved these changes
May 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many functions in the standard library already work with all iterables, so the argument types should be updated to reflect that. I also made small changes with negligible performance implications to
joinToStringandpermutationsto make them support iterables.Unrelated to the rest of the PR, I also changed
unzipto use theArraylength constructor instead ofArray.fromsinceArray.fromis for some reason much, much slower.