Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecation(encoding): deprecate base32.byteLength() #4000

Merged
merged 1 commit into from
Dec 20, 2023
Merged

deprecation(encoding): deprecate base32.byteLength() #4000

merged 1 commit into from
Dec 20, 2023
+2 −0

Conversation

iuioiua
Copy link
Collaborator

@iuioiua iuioiua commented Dec 20, 2023

Closes #3975

@iuioiua iuioiua requested a review from kt3k as a code owner December 20, 2023 06:31
kt3k
kt3k approved these changes Dec 20, 2023
View reviewed changes
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I think it's very rare that the user only want to know the length of encoded data without actually encoding it.

@iuioiua iuioiua merged commit bf7bb68 into main Dec 20, 2023
12 checks passed
@iuioiua iuioiua deleted the deprecate-base32.bytlength branch December 20, 2023 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kt3k kt3k kt3k approved these changes

Assignees
No one assigned
Labels
encoding
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

proposal: deprecate base32.byteLength() in the public API from std/encoding
2 participants
@iuioiua @kt3k