fix(fileserver):wrong url href of displayed files

[yuqingc]

#425

[CLAassistant]

All committers have signed the CLA.

[zekth]

https://github.com/denoland/deno_std/pull/426/files#diff-90919ab1e691a7a991a235f6b575c226R150
change:

const fileInfos = await readDir(dirPath);

by

const fileInfos = await readDir(dirPath);
dirPath = dirPath.replace(currentDir, "");

Also please format your code :) use:
deno run --allow-run --allow-write --allow-read format.ts

[zekth]

This is not good. We don't have to replace the dir on each occurence.

[yuqingc]

Thank you for your comment. I'll fix and test it now.

[ry]

Try using dirPath + "/" + info.name

[ry]

It would be great to get a test of this failure in http/file_server_test.ts...

[yuqingc]

Try using dirPath + "/" + info.name

The original version is dirPath + "/" + info.name. However, we get the absolute OS path of the current directory as dirPath, which is not correct. We should trim the prefix of currentDir here.

[yuqingc]

@zekth We should not modify the variable dirPath because there are codes using it below ( in line 161, stat(fn)), where stat needs the full path of a file as its argument.

[yuqingc]

@ry I have added two more test cases. All tests passed. Now the test would fail on either condition as you mentioned above.

[yuqingc]

Please hold this PR and do not merge for now. I have network problems and I have to retest the new commits when my nerwork works again.

[yuqingc]

Done. Deno.FileInfo is not compatible with Windows yet, which would raise an error during testing checking. Thus I added an extra checking of the platform.

[piscisaureus]

LGTM.
File mode is not a thing on windows any any attempts to emulate it are useless.