Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(semver): cleanup comparison functions #4266

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Feb 2, 2024

This change removes the internal use of the deprecated eq(), lt(), lte(), neq(), gt() and gte() functions.

This will make the future removal PR cleaner.

@iuioiua iuioiua requested a review from kt3k as a code owner February 2, 2024 00:30
@github-actions github-actions bot added the semver label Feb 2, 2024
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nice clean ups!

@iuioiua iuioiua merged commit 9bc4116 into main Feb 2, 2024
12 checks passed
@iuioiua iuioiua deleted the cleanup-semver-comparisons branch February 2, 2024 06:00
eryue0220 added a commit to eryue0220/deno_std that referenced this pull request Feb 2, 2024
…0/deno_std into crypto-noUncheckedIndexedAccess

* 'crypto-noUncheckedIndexedAccess' of github.com:eryue0220/deno_std:
  refactor(console): prepare for `noUncheckedIndexedAccess` (denoland#4269)
  refactor(collections): prepare for `noUncheckedIndexedAccess` (denoland#4268)
  refactor(semver): cleanup comparison functions (denoland#4266)
  chore(semver): postpone removal versions of some APIs (denoland#4267)
  BREAKING(log): remove `WARNING` log level (denoland#4258)
  BREAKING(semver): remove `rangeFormat()` (denoland#4265)
  BREAKING(semver): remove `sort()` (denoland#4264)
  BREAKING(path): remove `separator.ts` files (denoland#4260)
  BREAKING(path): remove `glob.ts` files (denoland#4259)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants