Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecation(console): copy std/console APIs into std/cli and deprecate std/console #4547

Merged
merged 1 commit into from
Apr 8, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented Apr 4, 2024

As part of #4326

@iuioiua iuioiua changed the title deprecation(console): merge std/console into std/cli deprecation(console): copy std/console APIs into std/cli and deprecate std/console Apr 4, 2024
@@ -14,6 +14,10 @@
* unicodeWidth("天地玄黃宇宙洪荒"); // 16
* ```
*
* @deprecated Use {@link https://jsr.io/@std/cli | std/cli} instead. This
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we sure about this?

@iuioiua iuioiua marked this pull request as ready for review April 5, 2024 07:16
@iuioiua iuioiua requested a review from kt3k as a code owner April 5, 2024 07:16
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 7630dd5 into main Apr 8, 2024
11 checks passed
@iuioiua iuioiua deleted the merge-console-cli branch April 8, 2024 04:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants