Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WebSocket] Add sec-websocket-version to handshake header #468

merged 1 commit into from May 30, 2019


2 participants
Copy link

commented May 30, 2019

I tried to communicate with deno_std WebSocket Client and a WebSocket Endpoint of Chrome DevTools, but handshake was rejected by Chrome.

I had to add a sec-websocket-version field to the request header to fix this.

According to the RFC, sec-websocket-version is required for the WebSocket Client implementation.

The request MUST include a header field with the name |Sec-WebSocket-Version|. The value of this header field MUST be 13.

cc: @keroxp


ry approved these changes May 30, 2019

Copy link

left a comment


@ry ry merged commit 40f55da into denoland:master May 30, 2019

5 checks passed

denoland.deno_std Build #20190530.11 succeeded
denoland.deno_std (Linux) Linux succeeded
denoland.deno_std (Mac) Mac succeeded
denoland.deno_std (Windows) Windows succeeded
license/cla Contributor License Agreement is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.