Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(collections): release collections@1.0.0 #4773

Merged
merged 3 commits into from
Jun 20, 2024
Merged

chore(collections): release collections@1.0.0 #4773

merged 3 commits into from
Jun 20, 2024

Conversation

iuioiua
Copy link
Contributor

@iuioiua iuioiua commented May 20, 2024

Reviews, please thoroughly review the source code and the documentation of this package and approve once:

  1. You foresee no breaking changes.
  2. Documentation and implementations are satisfactory, make sense, and don't raise concerns.

To be merged on June 20. Feedback from all is welcome before this package is stabilized.

Closes #4647

Copy link

codecov bot commented May 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.43%. Comparing base (6c598d5) to head (a743ed6).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4773   +/-   ##
=======================================
  Coverage   92.43%   92.43%           
=======================================
  Files         481      481           
  Lines       38746    38746           
  Branches     5449     5449           
=======================================
  Hits        35813    35813           
  Misses       2878     2878           
  Partials       55       55           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@lucacasonato lucacasonato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

@thisisjofrank thisisjofrank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iuioiua iuioiua merged commit 15ec8df into main Jun 20, 2024
15 checks passed
@iuioiua iuioiua deleted the collections-1 branch June 20, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

proposal: stabilize std/collections
4 participants