-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Installer: supports windows #499
Conversation
/cc @ry |
@axetroy can you replace code below |
Can you explain why you need to use |
Sure: right now it downloads remote file using |
@bardiarastin makes sense. I will finish it later. |
@bardiarastin I finished it, can you review it again? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last nitpicks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ref #497
Refer to the implementation of
npm
current supports run in
CMD
/PowerShell
/Git Bash
try it out
cmd
powershell
git bash