Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(io): undeprecate BufReader and BufWriter #5032

Closed
wants to merge 1 commit into from

Conversation

kt3k
Copy link
Member

@kt3k kt3k commented Jun 12, 2024

It seems that some active users exist for BufReader. So I suggest we should cancel the deprecation of these 2 classes

@github-actions github-actions bot added the io label Jun 12, 2024
Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.10%. Comparing base (0ad578f) to head (04d0e9d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5032   +/-   ##
=======================================
  Coverage   92.10%   92.10%           
=======================================
  Files         487      487           
  Lines       38798    38798           
  Branches     5432     5432           
=======================================
  Hits        35736    35736           
  Misses       3006     3006           
  Partials       56       56           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kt3k kt3k closed this Jun 14, 2024
@kt3k kt3k deleted the undeprecate-buf-reader-writer branch June 14, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant