Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(archive,expect,io,log,toml,yaml): remove private and public access modifiers #5077

Merged
merged 6 commits into from
Jun 21, 2024
Merged

refactor(archive,expect,io,log,toml,yaml): remove private and public access modifiers #5077

merged 6 commits into from
Jun 21, 2024

Conversation

MadGanGithub
Copy link
Contributor

@MadGanGithub MadGanGithub commented Jun 18, 2024 •
edited by iuioiua
Loading

Closes #5066

Fixes:
Removed public keyword
Added separate declaration and constructor assignment

Replaced private key with # keyword

@MadGanGithub MadGanGithub requested a review from kt3k as a code owner June 18, 2024 12:45
@CLAassistant
Copy link

CLAassistant commented Jun 18, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@iuioiua iuioiua changed the title replaced public and private access modifiers #5066 refactor(archive,expect,io,log,toml,yaml): remove private and public access modifiers Jun 18, 2024
iuioiua
iuioiua suggested changes Jun 18, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks mostly good. There are a few nits that need to be addressed. Can you please run deno fmt to format the code?

io/_test_common.ts Outdated Show resolved Hide resolved
io/buf_reader.ts Outdated Show resolved Hide resolved
io/string_writer.ts Outdated Show resolved Hide resolved
yaml/_error.ts Outdated Show resolved Hide resolved
yaml/_loader/loader_state.ts Show resolved Hide resolved
@kt3k
Copy link
Member

kt3k commented Jun 19, 2024

Also please sign the CLA from the above @CLAassistant's comment.

iuioiua
iuioiua approved these changes Jun 21, 2024
View reviewed changes
Copy link
Contributor

@iuioiua iuioiua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've taken the liberty of formatting and applying the suggested changes to take this over the line. Thank you for your contribution.

@iuioiua iuioiua merged commit ab458a3 into denoland:main Jun 21, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iuioiua iuioiua iuioiua approved these changes

@kt3k kt3k Awaiting requested review from kt3k kt3k is a code owner

Assignees
No one assigned
Labels
archive expect io log toml yaml
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

to-do: remove access modifiers across the codebase
4 participants
@MadGanGithub @CLAassistant @kt3k @iuioiua