Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types in example_client for ws module #609

Merged
merged 2 commits into from
Sep 21, 2019

Conversation

dsseng
Copy link
Contributor

@dsseng dsseng commented Sep 21, 2019

It didn't compile due to Promise type issue

@ry ry merged commit a4a8bb2 into denoland:master Sep 21, 2019
@dsseng dsseng deleted the chore/fix-example-client branch September 22, 2019 05:40
ry pushed a commit to ry/deno that referenced this pull request Oct 9, 2019
inverted-capital pushed a commit to dreamcatcher-tech/napps that referenced this pull request Oct 24, 2024
denoland#609)

Summary:
* The user is no longer required to be signed in to view the submit
page.
* The user still must be signed in to submit (post to `POST /submit`).
* Moved session assertion for `POST /api/items/[id]/vote` and `DELETE
/api/items/[id]/vote` to the session plugin.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants