Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node/events): Accept only functions as listener arguments #916

Merged

Conversation

uki00a
Copy link
Contributor

@uki00a uki00a commented May 12, 2021

Part of #911

This PR enables test-event-emitter-invalid-listener.js and aligns node/events to it.

Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@uki00a Thanks! LGTM

@kt3k kt3k merged commit 0dd98c7 into denoland:main May 13, 2021
@uki00a uki00a deleted the event-emitter-should-check-type-of-listener-arg branch May 13, 2021 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants