fix(equal): account for Weak* objects #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
- `WeakMap` and `WeakSet` cannot be deeply compared (no `size`, `Symbol.iterator`, etc.) - `WeakRef` can be dereferenced Refs denoland#949
mfulton26
force-pushed
the
fix/assertEquals/WeakObjects
branch
from
1fb89af
to
e5ceb9d
Compare
kt3k
approved these changes
Jun 7, 2021
|
Hi @mfulton26 @kt3k I think this (linked to #949) might have broken something? I'm getting an error due to 'WeakRef' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WeakMapandWeakSetcannot be deeply compared (nosize,Symbol.iterator, etc.)WeakRefcan be dereferencedRefs #949