Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request with no body are setting request.body to a ReadableStream #41

Closed
kitsonk opened this issue Apr 19, 2021 · 0 comments · Fixed by #42
Closed

Request with no body are setting request.body to a ReadableStream #41

kitsonk opened this issue Apr 19, 2021 · 0 comments · Fixed by #42
Assignees
@lucacasonato
Labels
bug Something isn't working

Comments

@kitsonk
Copy link

kitsonk commented Apr 19, 2021

Unlike Deploy and the native HTTP bindings in Deno 1.9 and later, deployctl sets the .body property to a ReadableStream even when there is no body. When there is no body, .body should be set to null.
@lucacasonato lucacasonato self-assigned this Apr 19, 2021
@lucacasonato lucacasonato added the bug Something isn't working label Apr 19, 2021
@lucacasonato lucacasonato mentioned this issue Apr 19, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lucacasonato lucacasonato

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: use Deno.serveHttp internally denoland/deployctl
2 participants
@kitsonk @lucacasonato