-
Notifications
You must be signed in to change notification settings - Fork 312
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: v8::Inspector::exception_thrown, v8::Inspector::create_stack_trace #1149
feat: v8::Inspector::exception_thrown, v8::Inspector::create_stack_trace #1149
Conversation
…#16943) Currently runtime exception are only displayed at the program end in terminal, which makes it only a partial fix, as a full fix requires denoland/rusty_v8#1149 which adds new bindings to the inspector that allows to notify it about thrown exceptions. This will be handled in a follow up commit.
url: StringView, | ||
line_number: u32, | ||
column_number: u32, | ||
stack_trace: UniquePtr<V8StackTrace>, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this argument optional?
If it is required, the type should be UniqueRef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub fn create_stack_trace( | ||
&mut self, | ||
stack_trace: Local<StackTrace>, | ||
) -> UniquePtr<V8StackTrace> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does create_stack_trace()
ever return nullptr?
If not, the return type should be UniqueRef.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it does, we discussed this in #717 (comment)
…ace (denoland#1149) Adds APIs required to notify inspector about exceptions raised by the runtime.
Revival of #717
Closes #715