Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update use of deprecated APIs #1481

Merged
merged 4 commits into from
May 15, 2024

Conversation

bartlomieju
Copy link
Member

This commit updates APIs related to named and indexed property
handlers to not use deprecated V8 APIs. Main change is the change
of return value in callbacks that now requires to return v8::Intercepted enum.

Towards #1478

Copy link
Contributor

@mmastrac mmastrac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I hope this fixes the deleter issue.

@bartlomieju bartlomieju enabled auto-merge (squash) May 15, 2024 23:12
@bartlomieju bartlomieju merged commit cf3f19c into denoland:main May 15, 2024
15 checks passed
@bartlomieju bartlomieju deleted the update_deprecated_apis branch May 15, 2024 23:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants