Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two period suffix looks out of place #25

Closed
skalnik opened this issue Dec 10, 2020 · 2 comments
Closed

Two period suffix looks out of place #25

skalnik opened this issue Dec 10, 2020 · 2 comments

Comments

@skalnik
Copy link

skalnik commented Dec 10, 2020

This plugin is great! Thank you so much for the work on it. After I installed it, I thought the .. suffix for most statuses was some bug with joining things into the status bar, but after looking at the source code, I see it is intentional: https://github.com/denolehov/obsidian-git/blob/master/main.ts#L477-L500

I was curious why you chose to add that. It felt a bit out of place on my status bar.

Screen Shot 2020-12-09 at 10 38 04 🌃

I figured I'd ask before sending you a PR 😀

@denolehov
Copy link
Collaborator

Hey @skalnik, it's just a personal preference :D

@skalnik
Copy link
Author

skalnik commented Dec 11, 2020

Fair enough! Thanks for the info. I'll leave it as be since it's on purpose 😀

@skalnik skalnik closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants