Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

-A flag (--config flag?) doesn’t work #92

Open
brainkim opened this issue Aug 19, 2020 · 5 comments
Open

-A flag (--config flag?) doesn’t work #92

brainkim opened this issue Aug 19, 2020 · 5 comments
Labels
bug Something isn't working

Comments

@brainkim
Copy link

brainkim commented Aug 19, 2020

Describe the bug

denon run -A --config tsconfig.json main.ts

The above command will error:

[!] [conf] unsupported configuration `-A`

If I remove the -A flag the above command will error:

[!] [conf] unsupported configuration `--config`

To Reproduce
Run the command.

Expected behavior
All flags passed to denon work like deno.

Configuration or Project
If applicable, add your denon configuration file or project so we can accurately test our solution.

Screenshots
If applicable, add screenshots to help explain your problem.

Setup (Edited for upgrade)

  • OS: macOS mojave 10.14.6
  • Deno version: 1.3.0
  • Denon version: 2.3.2-master

Additional context
Sorry if this was solved already, just wanted to log it while I was crawling the information superhighway.

@brainkim brainkim added the bug Something isn't working label Aug 19, 2020
@notfilippo
Copy link
Collaborator

You are on a previous version of denon (2.3.1), you should probably upgrade to the latest version (denon --upgrade).

If the error persist please let me know 🌈

@brainkim
Copy link
Author

brainkim commented Aug 19, 2020

Hmmm. I upgraded denon and deno to latest. It still happens but my initial reproduction is incorrect. I’m using both the -A flag and --config flag. If I use the --config flag it marks the --config flag as unknown. If I use the -A flag before the config flag it marks the -A flag as unknown instead.

Maybe the issue is that the --config flag is not supported. I’m currently just noodling around with some stuff, if you need a full reproduction I’ll try to get it to you.

@brainkim brainkim changed the title -A flag doesn’t work -A flag (--config flag?) doesn’t work Aug 19, 2020
@hong4rc
Copy link
Contributor

hong4rc commented Dec 7, 2020

I have some idea:

  • --config flag conflict with --config flag of deno, we can change to another name for config or ignore --config flag if no command (use for others option)
  • --version flag must be show deno's version too

@hong4rc
Copy link
Contributor

hong4rc commented Dec 7, 2020

1bd2929

@eliassjogreen Can you revert the check option in that commit?

I think we only allow the option if it is the first argument.
image

@eliassjogreen
Copy link
Member

Create a pr for it if you want it reverted as i don't really know what exactly you want done. This issue should really be resolved by renaming denons --config flag to something like denon-config or we could do something which would be kinda hard but smart which is to just look at the provided config and if it looks like a denon config treat it as such otherwise revert back to using it as a tsconfig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants