Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddrimport entity hanging on Identifier #90

Closed
sarabeckman opened this issue Sep 5, 2018 · 9 comments
Closed

ddrimport entity hanging on Identifier #90

sarabeckman opened this issue Sep 5, 2018 · 9 comments
Assignees

Comments

@sarabeckman
Copy link
Collaborator

ddrimportentitybug

ddrimport entity is not moving past the first DDR.identifier.Identifier collection step. The process doesn't stop and I have to manually cancel out of the operation.

I'm running master version 2.6.1 on my local VM. My local VM is also running stretch.

@gjost
Copy link
Member

gjost commented Sep 6, 2018

I confirmed that contents of the log on kinkura agree with the screenshot. I copied the CSV to my local dev environment and ran it on a local copy of that collection but was not able to duplicate the error.

Before we do anything else, can you update your copy of ddrlocal? It's a couple versions behind.

@sarabeckman
Copy link
Collaborator Author

I updated my copy to version 2.6.3 and I tried running the same ddrimport entity command and I got the same result.

@gjost
Copy link
Member

gjost commented Sep 7, 2018

I've downloaded both the CSV (ddr-csujad-14-entities-20180501-1049.csv) and the repository itself from kinkura to my local system. I also rolled back all the DDR components (ddr-defs, ddr-cmdln, ddr-local) to the where they are in 2.6.3 and recompiled everything from scratch. Unfortunately I still haven't been able to duplicate this bug.
Next I'll look through the source code and see what's going on at the point where it seems to get stuck.
If that doesn't work I'll install on a Debian Stretch system and see if that makes a difference.

@gjost
Copy link
Member

gjost commented Sep 7, 2018

In future bug reports, it's better to cut-and-paste text from the terminal rather than take screenshots. This makes it a lot easier to work with paths and stuff, cut-and-paste rather than squint and type.

Thanks for including the version number and the host OS.

@gjost
Copy link
Member

gjost commented Sep 7, 2018

I notice the command does not include the ID service username or password. Did you have these in environment variables, e.g. export IDSERVICE_ENVIRONMENT_USERNAME=redacted?

I ask because the very next thing that happens after the collection identifier gets printed (the last thing before it hangs) is the ID service login. If username is not in an environment variable, you'll get a username prompt.

Once ddrimport has a username/password, it attempts to contact the ID service. What happens if you run elinks https://idservice.densho.org on that VM? You should see a popup, where you should select "show header". You should then see some JSON. If you can't see this, you have a bad connection with the ID service.

@sarabeckman
Copy link
Collaborator Author

Aha! okay I added my ID service username and password to the command and the command worked!

@gjost
Copy link
Member

gjost commented Sep 7, 2018 via email

@gjost gjost closed this as completed Sep 7, 2018
@gjost gjost reopened this Sep 7, 2018
@gjost
Copy link
Member

gjost commented Sep 17, 2018

Fixed in 9906b50.

@gjost gjost closed this as completed Sep 17, 2018
@gjost
Copy link
Member

gjost commented Sep 19, 2018

Fixed in ea770a6.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants