Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XZ curve & M30 issues #9

Closed
pihnat opened this issue Oct 23, 2015 · 10 comments
Closed

XZ curve & M30 issues #9

pihnat opened this issue Oct 23, 2015 · 10 comments

Comments

@pihnat
Copy link

pihnat commented Oct 23, 2015

Hi,
I've discovered a couple more small quirks with grblControl:

  1. M30 when executed should move the highlighted G-code line back to the first line
  2. When creating an arc in the XZ plane the Arduino performs the correct movement with the tool however the visualiser draws a straight line instead of an arc. Try this:
    G90
    G18
    G21
    F200
    G0 X0 Y0 Z0
    G1 X5
    G3 X5 Z10 I0 K5
    M30

If you replace the G3 line with
G3 X5 Z10 R5
the motion is also correct except the visualiser doesn't display any arc or line.

kind regards
Peter

@Denvi
Copy link
Owner

Denvi commented Oct 23, 2015

  1. Accepted.
  2. Now, as the arc axis is only supported axis Z. Others will be added in future (G17, G18, G19 codes).

@pihnat
Copy link
Author

pihnat commented Oct 25, 2015

The reason I am asking about arc support in M18 (xz) mode is because I have tried grblControl with a lathe. It works very well except the 3D pic is vertical instead of horizontal because lathes use X and Z. However the path of the tool is correct except for the arc.
Do you have any plans to one day implement a lathe mode? It could be a setting where you select mill or lathe view.

@Denvi
Copy link
Owner

Denvi commented Oct 28, 2015

Do you have any plans to one day implement a lathe mode? It could be a setting where you select mill or lathe view.

At the moment no such plans.

@Denvi
Copy link
Owner

Denvi commented Oct 30, 2015

G17, G18, G19 commands support added.
Tested with following program:

G90
G18
G21
F200
G0 X0 Y0 Z0
G1 X5
G3 X5 Z10 I0 K5
G19
G3 X5 Z0 I0 K-5
G17
G3 X0 Z0 I-2.5 K0
M30

@Denvi
Copy link
Owner

Denvi commented Oct 31, 2015

Processing of the M2 & M30 commands is fixed.

@pihnat
Copy link
Author

pihnat commented Nov 1, 2015

Still a slight problem with G18. Try the following
G90
G21
F200
G18
G00 X0 Y0 Z0
G01 X7 Z0
G03 X7 Z-20 I-7.0 K-10
G01 X7 Z-24
G01 X14 Z-24
M30

The arc is drawn in-correctly but when Sending the tool does trace the correct path in the 3D view.

@Denvi
Copy link
Owner

Denvi commented Nov 2, 2015

Radius calculation problem. Fixed.

@pihnat
Copy link
Author

pihnat commented Nov 2, 2015

I just downloaded it and it works perfectly in xz plane.
However now in xy plane the same problem appears as was in the xz plane with arcs having tails. Attached is a pic with a heart shape - right hand picture is using old exe file, left pic is the current exe file. The shapes are drawn in xy plane, G17.

error

@Denvi
Copy link
Owner

Denvi commented Nov 3, 2015

Meanwhile I commited the intermediate version. I will test more.

@pihnat
Copy link
Author

pihnat commented Nov 3, 2015

It's working now, xy and xz arcs are good. I will keep testing too.

@pihnat pihnat closed this as completed Nov 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants