Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove OT status for cases that are reassigned #14366

Closed
7 tasks
araposo-tistatech opened this issue May 21, 2020 · 3 comments · Fixed by #14453 or #14690
Closed
7 tasks

Remove OT status for cases that are reassigned #14366

araposo-tistatech opened this issue May 21, 2020 · 3 comments · Fixed by #14453 or #14690
Assignees
@lomky
Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: New Development New feature development
Milestone
PI4-S6: Sea of Tr...

Comments

@araposo-tistatech
Copy link

araposo-tistatech commented May 21, 2020 •
edited by AnalystMarie
Loading

Description

In the following situations the overtime status should be removed from the case:

Judge or case movement user reassigns case to another judge
Judge or case movement user reassigns attorney task to a new attorney

Acceptance criteria

  • This is only done for workmodes on an appeal, not updating the vacols decass record or attorney case review
  • OT status is removed when a judge or case movement user reassigns a case to another judge
    • Ama
    • Legacy
  • OT status is removed when a judge or case movement user reassigns an attorney task to another attorney
    • Ama
    • Legacy

Background/context/resources

Slack Conversation

Technical notes
@araposo-tistatech araposo-tistatech added Product: caseflow-queue Team: Echo 🐬 Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Type: New Development New feature development labels May 21, 2020
@ajspotts
Copy link
Contributor

what is this chart?

1 | 
2 | 
3 | ||||||||||||
5 | 
8 |

might be two PRs, unless the changes are straightforward.

Why 1?

Why 2?

Why 3?

  • Unsure of where this should happen. Easy enough to do in the reassign function to do a check on the task type
  • Unsure of where this is handled for legacy appeals, probably.
    • can we reassign judges and atty in Caseflow for legacy appeals?
    • Only reassign judge tasks at judge assign, updated AC ☑️ 🎉

@hschallhorn hschallhorn mentioned this issue Jun 1, 2020
Closed
@hschallhorn hschallhorn added this to the PI4-S3: XXX Sprint milestone Jun 1, 2020
@hschallhorn hschallhorn self-assigned this Jun 2, 2020
This was referenced Jun 2, 2020
Closed
Merged
Merged
Merged
va-bot pushed a commit that referenced this issue Jun 9, 2020
@hschallhorn
[PART 1] Remove attorney task cancellation hook (#14448)
69d7138 
# FULL STACK

PART 1: Remove attorney task cancellation hook #14448
PART 2: Perform "caseflow" reassign of attorney tasks #14452
PART 3: Remove overtime status of appeal if case is reassigned #14453

# THIS PR

Resolves #14181

PART 1 in stack to implement #14366
PART 2 #14452
PART 3 #14453

### Description
Calls send_back_to_judge_assign! directly when cancelling an attorney task rather than relying on a callback.

### Acceptance Criteria
- [x] Hook for sending a case back to judge reassign on attorney task cancellation is removed.

### Testing Plan
1. Log in as BVACASPER
1. Go to any ama attorney task
1. Select "Cancel Task & return to judge"
1. Ensure the attorney and judge decision review task are cancelled and a judge assign task was opened
```ruby
uuid = ""
Appeal.find_by_uuid(uuid).treee
                                  ┌────────────────────────────────────────────────────────────────────────┐
Appeal 682 (evidence_submission)  │ ID   │ STATUS    │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                      │ 2027 │ on_hold   │             │ Bva         │ 2020-05-22 14:50:19 UTC │
    ├── JudgeDecisionReviewTask   │ 2028 │ cancelled │             │ BVAAABSHIRE │ 2020-06-02 18:19:56 UTC │
    │   └── AttorneyTask          │ 2029 │ cancelled │ BVAAABSHIRE │ BVAEERDMAN  │ 2020-06-02 18:19:55 UTC │
    └── JudgeAssignTask           │ 2532 │ assigned  │             │ BVAAABSHIRE │ 2020-06-02 18:19:56 UTC │
                                  └────────────────────────────────────────────────────────────────────────┘
```
1. Cancel any attorney task by hand
```ruby
task = AttorneyTask.open.last
task.appeal.treee
Appeal 545 (direct_review) ──── │ ID   │ STATUS    │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                    │ 1458 │ on_hold   │             │ Bva         │ 2020-05-22 14:47:39 UTC │
    ├── DistributionTask        │ 1459 │ completed │             │ Bva         │ 2020-05-22 14:47:39 UTC │
    ├── JudgeAssignTask         │ 1460 │ completed │             │ BVAAABSHIRE │ 2020-06-01 14:34:38 UTC │
    ├── JudgeDecisionReviewTask │ 2493 │ cancelled │ BVAAABSHIRE │ BVAAABSHIRE │ 2020-06-01 14:52:39 UTC │
    │   └── AttorneyTask        │ 2494 │ cancelled │ BVAAABSHIRE │ BVAEERDMAN  │ 2020-06-01 14:52:39 UTC │
    ├── JudgeAssignTask         │ 2495 │ cancelled │             │ BVAAABSHIRE │ 2020-06-01 14:53:15 UTC │
    ├── JudgeAssignTask         │ 2496 │ completed │ BVAAABSHIRE │ BVAAABSHIRE │ 2020-06-01 18:17:36 UTC │
    └── JudgeDecisionReviewTask │ 2523 │ on_hold   │ BVARDUNKLE  │ BVAAABSHIRE │ 2020-06-01 18:17:36 UTC │
        └── AttorneyTask        │ 2524 │ assigned  │ BVARDUNKLE  │ BVAEERDMAN  │ 2020-06-01 18:17:36 UTC │

=> nil
task.cancelled!
```
1. Ensure this does not close the judge review task and does not open a judge assign task
```ruby
task.appeal.reload.treee
Appeal 545 (direct_review)       ID   STATUS    ASGN_BY     ASGN_TO     UPDATED_AT
└── RootTask                     1458 on_hold               Bva         2020-05-22 14:47:39 UTC
    ├── DistributionTask         1459 completed             Bva         2020-05-22 14:47:39 UTC
    ├── JudgeAssignTask          1460 completed             BVAAABSHIRE 2020-06-01 14:34:38 UTC
    ├── JudgeDecisionReviewTask  2493 cancelled BVAAABSHIRE BVAAABSHIRE 2020-06-01 14:52:39 UTC
    │   └── AttorneyTask         2494 cancelled BVAAABSHIRE BVAEERDMAN  2020-06-01 14:52:39 UTC
    ├── JudgeAssignTask          2495 cancelled             BVAAABSHIRE 2020-06-01 14:53:15 UTC
    ├── JudgeAssignTask          2496 completed BVAAABSHIRE BVAAABSHIRE 2020-06-01 18:17:36 UTC
    └── JudgeDecisionReviewTask  2523 assigned  BVARDUNKLE  BVAAABSHIRE 2020-06-02 19:45:16 UTC
        └── AttorneyTask         2524 cancelled BVARDUNKLE  BVAEERDMAN  2020-06-02 19:45:16 UTC
```

### User Facing Changes
 - [ ] None
@hschallhorn
Copy link
Contributor

Closed in #14452

@hschallhorn
Copy link
Contributor

Not complete!
ezgif-1-b0b5ed2bb8b2

Steps to reproduce:
Mark a legacy appeal as overtime and assign to an attorney
Go to the attorney’s queue in your assign page
Select the overtime legacy case and assign to another attorney
Go to case details of that case
Notice it still has an overtime badge

@hschallhorn hschallhorn reopened this Jul 9, 2020
@hschallhorn hschallhorn removed their assignment Jul 13, 2020
@lomky lomky self-assigned this Jul 14, 2020
@lomky lomky mentioned this issue Jul 14, 2020
Merged
3 tasks
va-bot pushed a commit that referenced this issue Jul 16, 2020
@lomky
Reassigning LegacyAppeal drafting to another attorney clears overtime…
bbcc6c8 
… status (#14690)

Resolves #14366 

### Description
Legacy Appeals assigned to an attorney for drafting marked for overtime will have that overtime status cleared if reassigned to another attorney

### Acceptance Criteria
- [ ] OT status is cleared for:
  - Legacy Appeals
    - Assigned to an attorney for drafting
    - Marked for overtime
  - that are then: Reassigned to another attorney

### Testing Plan
1. Checkout master
1. Exit all db access and run `make reset`
1. Disable DAS deprecation: `FeatureToggle.disable!(:legacy_das_deprecation)`
1. Sign in as Abshire and navigate to the [assign queue](http://localhost:3000/queue/BVAAABSHIRE/assign)
1. Mark Legacy Appeal `Evangeline R Mac Gyver` as OT, assign the case to Attorney Reanna
1. Navigate to the assign queue and click Attorney Reanna's work queue
1. Reassign the  `Evangeline R Mac Gyver` case to Lela 
   - [ ] OT status retained
1. checkout this branch! 
1. Reassign the  `Evangeline R Mac Gyver` case to Reanna
   - [ ] OT status removed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lomky lomky

Labels
Priority: Medium Blocking issue w/workaround, or "second in" priority for new work. Product: caseflow-queue Team: Echo 🐬 Type: New Development New feature development
Projects
None yet
Milestone
PI4-S6: Sea of Tranquility Sprint
4 participants
@lomky @ajspotts @hschallhorn @araposo-tistatech