[PART 1] Remove attorney task cancellation hook #14448

hschallhorn · 2020-06-02T19:46:16Z

FULL STACK

PART 1: Remove attorney task cancellation hook #14448
PART 2: Perform "caseflow" reassign of attorney tasks #14452
PART 3: Remove overtime status of appeal if case is reassigned #14453

THIS PR

Resolves #14181

PART 1 in stack to implement #14366
PART 2 #14452
PART 3 #14453

Description

Calls send_back_to_judge_assign! directly when cancelling an attorney task rather than relying on a callback.

Acceptance Criteria

Hook for sending a case back to judge reassign on attorney task cancellation is removed.

Testing Plan

Log in as BVACASPER
Go to any ama attorney task
Select "Cancel Task & return to judge"
Ensure the attorney and judge decision review task are cancelled and a judge assign task was opened

uuid = ""
Appeal.find_by_uuid(uuid).treee
                                  ┌────────────────────────────────────────────────────────────────────────┐
Appeal 682 (evidence_submission)  │ ID   │ STATUS    │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                      │ 2027 │ on_hold   │             │ Bva         │ 2020-05-22 14:50:19 UTC │
    ├── JudgeDecisionReviewTask   │ 2028 │ cancelled │             │ BVAAABSHIRE │ 2020-06-02 18:19:56 UTC │
    │   └── AttorneyTask          │ 2029 │ cancelled │ BVAAABSHIRE │ BVAEERDMAN  │ 2020-06-02 18:19:55 UTC │
    └── JudgeAssignTask           │ 2532 │ assigned  │             │ BVAAABSHIRE │ 2020-06-02 18:19:56 UTC │
                                  └────────────────────────────────────────────────────────────────────────┘

Cancel any attorney task by hand

task = AttorneyTask.open.last
task.appeal.treee
Appeal 545 (direct_review) ──── │ ID   │ STATUS    │ ASGN_BY     │ ASGN_TO     │ UPDATED_AT              │
└── RootTask                    │ 1458 │ on_hold   │             │ Bva         │ 2020-05-22 14:47:39 UTC │
    ├── DistributionTask        │ 1459 │ completed │             │ Bva         │ 2020-05-22 14:47:39 UTC │
    ├── JudgeAssignTask         │ 1460 │ completed │             │ BVAAABSHIRE │ 2020-06-01 14:34:38 UTC │
    ├── JudgeDecisionReviewTask │ 2493 │ cancelled │ BVAAABSHIRE │ BVAAABSHIRE │ 2020-06-01 14:52:39 UTC │
    │   └── AttorneyTask        │ 2494 │ cancelled │ BVAAABSHIRE │ BVAEERDMAN  │ 2020-06-01 14:52:39 UTC │
    ├── JudgeAssignTask         │ 2495 │ cancelled │             │ BVAAABSHIRE │ 2020-06-01 14:53:15 UTC │
    ├── JudgeAssignTask         │ 2496 │ completed │ BVAAABSHIRE │ BVAAABSHIRE │ 2020-06-01 18:17:36 UTC │
    └── JudgeDecisionReviewTask │ 2523 │ on_hold   │ BVARDUNKLE  │ BVAAABSHIRE │ 2020-06-01 18:17:36 UTC │
        └── AttorneyTask        │ 2524 │ assigned  │ BVARDUNKLE  │ BVAEERDMAN  │ 2020-06-01 18:17:36 UTC │

=> nil
task.cancelled!

Ensure this does not close the judge review task and does not open a judge assign task

task.appeal.reload.treee
Appeal 545 (direct_review)       ID   STATUS    ASGN_BY     ASGN_TO     UPDATED_AT
└── RootTask                     1458 on_hold               Bva         2020-05-22 14:47:39 UTC
    ├── DistributionTask         1459 completed             Bva         2020-05-22 14:47:39 UTC
    ├── JudgeAssignTask          1460 completed             BVAAABSHIRE 2020-06-01 14:34:38 UTC
    ├── JudgeDecisionReviewTask  2493 cancelled BVAAABSHIRE BVAAABSHIRE 2020-06-01 14:52:39 UTC
    │   └── AttorneyTask         2494 cancelled BVAAABSHIRE BVAEERDMAN  2020-06-01 14:52:39 UTC
    ├── JudgeAssignTask          2495 cancelled             BVAAABSHIRE 2020-06-01 14:53:15 UTC
    ├── JudgeAssignTask          2496 completed BVAAABSHIRE BVAAABSHIRE 2020-06-01 18:17:36 UTC
    └── JudgeDecisionReviewTask  2523 assigned  BVARDUNKLE  BVAAABSHIRE 2020-06-02 19:45:16 UTC
        └── AttorneyTask         2524 cancelled BVARDUNKLE  BVAEERDMAN  2020-06-02 19:45:16 UTC

User Facing Changes

None

spec/factories/user.rb

hschallhorn · 2020-06-02T19:48:06Z

app/controllers/tasks_controller.rb

+    if task.is_a?(AttorneyTask) && update_params[:status].eql?(Constants.TASK_STATUSES.cancelled)
+      task.verify_user_can_update!(current_user)
+
+      return task.send_back_to_judge_assign!


Call send_back_to_judge_assign! directly rather than cancelling the attorney task and relying on the hook to cancel/open tasks

I'm a bit grumpy at having this in controller. Thinking about it

can we instead override update_from_params inside of AttorneyTask, and do this logic there?

Yes we can! Alec and I were fiddling with where this should go. Didn't want this to have any unintended consequences as we obviously struggled with when it was a cancellation hook.

codeclimate · 2020-06-02T19:51:15Z

Code Climate has analyzed commit 26ae658 and detected 0 issues on this pull request.

View more on Code Climate.

hschallhorn · 2020-06-02T20:55:11Z

app/workflows/bulk_task_reassignment.rb

@@ -246,7 +246,8 @@ def reassign_attorney_tasks
  end

  def reassign_attorney_task(task)
-    update_task_status_with_instructions(task, Constants.TASK_STATUSES.cancelled)
+    task.send_back_to_judge_assign!
+    task.update_with_instructions(instructions: reassignment_instructions(Constants.TASK_STATUSES.cancelled))


we were previously relying on the cancellation hook here. Call the function instead.

hschallhorn · 2020-06-03T16:08:48Z

Batteam wikis that need updating:
https://github.com/department-of-veterans-affairs/appeals-deployment/wiki/Bat-Team-Quick-Ref#reassign-inactive-attorneys-tasks
https://github.com/department-of-veterans-affairs/appeals-deployment/wiki/Bat-Team-Quick-Ref#cancel-an-attorney-task--return-to-judge-assign-queue

lomky

Some thoughts!

lomky · 2020-06-03T16:10:36Z

app/controllers/tasks_controller.rb

+    if task.is_a?(AttorneyTask) && update_params[:status].eql?(Constants.TASK_STATUSES.cancelled)
+      task.verify_user_can_update!(current_user)
+
+      return task.send_back_to_judge_assign!


I'm a bit grumpy at having this in controller. Thinking about it

lomky · 2020-06-03T16:11:54Z

app/controllers/tasks_controller.rb

+    if task.is_a?(AttorneyTask) && update_params[:status].eql?(Constants.TASK_STATUSES.cancelled)
+      task.verify_user_can_update!(current_user)
+
+      return task.send_back_to_judge_assign!


can we instead override update_from_params inside of AttorneyTask, and do this logic there?

spec/factories/user.rb

spec/controllers/tasks_controller_spec.rb

Co-authored-by: Kat Tipton <kat@navapbc.com>

…ation-hook

lomky

One last optional swap. Hurray unhooking stuff! ↪️

app/models/tasks/attorney_task.rb

spec/factories/user.rb

* User proper reassign params when reassigning an attorney task * Remove changes * [PART 3] Remove overtime status of appeal if case is reassigned (#14453) * Remove overtime status on judge or attorney reassignment * Wip * Properly set overtime to false when reassigning * Undo changes * lint * Clear suvccess messages

…ation-hook

va-bot · 2020-06-09T16:21:42Z

	1 Warning
⚠️	This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

…ation-hook

Remove attorney task cancellation hook

7a74a56

hschallhorn commented Jun 2, 2020

View reviewed changes

spec/factories/user.rb Show resolved Hide resolved

hschallhorn commented Jun 2, 2020

View reviewed changes

hschallhorn self-assigned this Jun 2, 2020

hschallhorn added 2 commits June 2, 2020 16:43

CC

7c9ebec

Fix tests

627d6e7

hschallhorn commented Jun 2, 2020

View reviewed changes

CC

d3e5117

hschallhorn requested a review from lomky June 3, 2020 15:09

This was referenced Jun 3, 2020

[PART 3] Remove overtime status of appeal if case is reassigned #14453

Merged

[PART 2] Perform "caseflow" reassign of attorney tasks #14452

Merged

lomky reviewed Jun 3, 2020

View reviewed changes

hschallhorn and others added 3 commits June 4, 2020 09:51

words words words

2bb733a

Co-authored-by: Kat Tipton <kat@navapbc.com>

Override update_from_params

a9e83c7

Merge branch 'master' into hschallhorn/14366-remove-atty-task-cancell…

fa9d3b9

…ation-hook

lomky approved these changes Jun 4, 2020

View reviewed changes

app/models/tasks/attorney_task.rb Outdated Show resolved Hide resolved

spec/factories/user.rb Show resolved Hide resolved

hschallhorn and others added 5 commits June 4, 2020 10:36

Rename factories

528a9cd

Function for params

a3be854

Typo

02fe7d8

Do

5844adf

- fit

28f224f

hschallhorn changed the title ~~Remove attorney task cancellation hook~~ [PART 1] Remove attorney task cancellation hook Jun 4, 2020

hschallhorn added 2 commits June 9, 2020 12:19

Merge branch 'master' into hschallhorn/14366-remove-atty-task-cancell…

979b9a5

…ation-hook

hschallhorn added the Ready-to-Merge This PR is ready to be merged and will be picked up by va-bot to automatically merge to master label Jun 9, 2020

hschallhorn and others added 2 commits June 9, 2020 13:03

Fix merge

d8e00ea

Merge branch 'master' into hschallhorn/14366-remove-atty-task-cancell…

e0cf016

…ation-hook

Fix test

26ae658

va-bot merged commit 69d7138 into master Jun 9, 2020

va-bot deleted the hschallhorn/14366-remove-atty-task-cancellation-hook branch June 9, 2020 19:45

hschallhorn mentioned this pull request Sep 14, 2020

Cancellation of an AttorneyRewriteTask should reactivate JudgeDecisionReviewTask, not JudgeAssignTask #15218

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PART 1] Remove attorney task cancellation hook #14448

[PART 1] Remove attorney task cancellation hook #14448

hschallhorn commented Jun 2, 2020 •

edited

Loading

hschallhorn Jun 2, 2020

lomky Jun 3, 2020

lomky Jun 3, 2020

hschallhorn Jun 4, 2020

codeclimate bot commented Jun 2, 2020 •

edited

Loading

hschallhorn Jun 2, 2020

hschallhorn commented Jun 3, 2020

lomky left a comment

lomky Jun 3, 2020

lomky Jun 3, 2020

lomky left a comment

va-bot commented Jun 9, 2020 •

edited

Loading

[PART 1] Remove attorney task cancellation hook #14448

[PART 1] Remove attorney task cancellation hook #14448

Conversation

hschallhorn commented Jun 2, 2020 • edited Loading

FULL STACK

THIS PR

Description

Acceptance Criteria

Testing Plan

User Facing Changes

hschallhorn Jun 2, 2020

Choose a reason for hiding this comment

lomky Jun 3, 2020

Choose a reason for hiding this comment

lomky Jun 3, 2020

Choose a reason for hiding this comment

hschallhorn Jun 4, 2020

Choose a reason for hiding this comment

codeclimate bot commented Jun 2, 2020 • edited Loading

hschallhorn Jun 2, 2020

Choose a reason for hiding this comment

hschallhorn commented Jun 3, 2020

lomky left a comment

Choose a reason for hiding this comment

lomky Jun 3, 2020

Choose a reason for hiding this comment

lomky Jun 3, 2020

Choose a reason for hiding this comment

lomky left a comment

Choose a reason for hiding this comment

va-bot commented Jun 9, 2020 • edited Loading

hschallhorn commented Jun 2, 2020 •

edited

Loading

codeclimate bot commented Jun 2, 2020 •

edited

Loading

va-bot commented Jun 9, 2020 •

edited

Loading