[PART 3] Remove overtime status of appeal if case is reassigned #14453

hschallhorn · 2020-06-02T20:38:52Z

Resolves #14366

PART 3 in stack to implement #14366
PART 1 #14448
PART 2 #14452

Description

If an appeal has been designated as "overtime approved" remove this status if the case is assigned to another judge or attorney.

Acceptance Criteria

OT status is removed when a judge or case movement user reassigns a case to another judge
- Ama
- Legacy
OT status is removed when a judge or case movement user reassigns an attorney task to another attorney
- Ama

Testing Plan

AMA Judge

Log in as bvaabshire
Mark an ama case as overtime
Reassign the case to another judge and go back to case details without refreshing
Ensure the case is no longer marked as overtime

AMA Attorney

Mark an ama case as overtime
Assign it to an attorney
Reassign the case to another attorney and go back to case details without refreshing
Ensure the case is no longer marked as overtime

Legacy Judge

Mark a legacy case as overtime
Reassign the case to another judge and go back to case details without refreshing
Ensure the case is no longer marked as overtime

User Facing Changes

NONE

codeclimate · 2020-06-02T20:44:29Z

Code Climate has analyzed commit 3cb011e and detected 3 issues on this pull request.

Here's the issue category breakdown:

Category	Count
Style	3

View more on Code Climate.

…to hschallhorn/14366-remove-ot-on-reassignment

va-bot · 2020-06-03T19:10:27Z

	1 Warning
⚠️	This PR modifies React components — consider adding/updating corresponding Storybook file

Generated by 🚫 Danger

hschallhorn · 2020-06-04T15:25:43Z

app/controllers/legacy_tasks_controller.rb

@@ -96,6 +96,9 @@ def assign_to_judge
    # update the location to the assigned judge.
    QueueRepository.update_location_to_judge(appeal.vacols_id, assigned_to)

+    # Remove overtime status of an appeal when reassigning to a judge
+    appeal.overtime = false if appeal.overtime?


We do not need a feature toggle check here as overtime? returns false if the feature toggle is not enabled

hschallhorn · 2020-06-04T15:27:57Z

client/app/queue/AssignToView.jsx

@@ -145,6 +145,9 @@ class AssignToView extends React.Component {

    return this.props.requestPatch(`/tasks/${task.taskId}`, payload, successMsg).then((resp) => {
      this.props.onReceiveAmaTasks(resp.body.tasks.data);
+      if (task.type === 'JudgeAssignTask') {
+        this.props.setOvertime(task.externalAppealId, false);
+      }


On reassign of a judge assign task: Ensure we update the redux store to reflect that this appeal's overtime status is now false

hschallhorn · 2020-06-04T15:28:15Z

client/app/queue/QueueActions.js

@@ -557,6 +559,8 @@ export const legacyReassignToJudge = ({
      dispatch(onReceiveTasks(_.pick(allTasks, ['tasks', 'amaTasks'])));

      dispatch(showSuccessMessage(successMessage));
+
+      dispatch(setOvertime(oldTask.externalAppealId, false));


On reassign of a legacy judge assign task: Ensure we update the redux store to reflect that this appeal's overtime status is now false

hschallhorn · 2020-06-04T15:28:26Z

client/app/queue/QueueActions.js

@@ -534,6 +534,8 @@ export const reassignTasksToUser = ({
      dispatch(decrementTaskCountForAttorney({
        id: previousAssigneeId
      }));
+
+      dispatch(setOvertime(oldTask.externalAppealId, false));


On reassign of an attorney assign task: Ensure we update the redux store to reflect that this appeal's overtime status is now false

hschallhorn · 2020-06-09T14:30:33Z

client/app/queue/AssignToView.jsx

@@ -59,6 +59,8 @@ class AssignToView extends React.Component {
    };
  }

+  componentDidMount = () => this.props.resetSuccessMessages();


Fixes the below!

hschallhorn · 2020-06-09T14:30:40Z

client/app/queue/components/AssignToAttorneyWidget.jsx

@@ -47,6 +47,8 @@ class AssignToAttorneyWidget extends React.PureComponent {
    };
  }

+  componentDidMount = () => this.props.resetSuccessMessages();


Fixes the below!

ajspotts

🚀

* User proper reassign params when reassigning an attorney task * Remove changes * [PART 3] Remove overtime status of appeal if case is reassigned (#14453) * Remove overtime status on judge or attorney reassignment * Wip * Properly set overtime to false when reassigning * Undo changes * lint * Clear suvccess messages

# FULL STACK PART 1: Remove attorney task cancellation hook #14448 PART 2: Perform "caseflow" reassign of attorney tasks #14452 PART 3: Remove overtime status of appeal if case is reassigned #14453 # THIS PR Resolves #14181 PART 1 in stack to implement #14366 PART 2 #14452 PART 3 #14453 ### Description Calls send_back_to_judge_assign! directly when cancelling an attorney task rather than relying on a callback. ### Acceptance Criteria - [x] Hook for sending a case back to judge reassign on attorney task cancellation is removed. ### Testing Plan 1. Log in as BVACASPER 1. Go to any ama attorney task 1. Select "Cancel Task & return to judge" 1. Ensure the attorney and judge decision review task are cancelled and a judge assign task was opened ```ruby uuid = "" Appeal.find_by_uuid(uuid).treee ┌────────────────────────────────────────────────────────────────────────┐ Appeal 682 (evidence_submission) │ ID │ STATUS │ ASGN_BY │ ASGN_TO │ UPDATED_AT │ └── RootTask │ 2027 │ on_hold │ │ Bva │ 2020-05-22 14:50:19 UTC │ ├── JudgeDecisionReviewTask │ 2028 │ cancelled │ │ BVAAABSHIRE │ 2020-06-02 18:19:56 UTC │ │ └── AttorneyTask │ 2029 │ cancelled │ BVAAABSHIRE │ BVAEERDMAN │ 2020-06-02 18:19:55 UTC │ └── JudgeAssignTask │ 2532 │ assigned │ │ BVAAABSHIRE │ 2020-06-02 18:19:56 UTC │ └────────────────────────────────────────────────────────────────────────┘ ``` 1. Cancel any attorney task by hand ```ruby task = AttorneyTask.open.last task.appeal.treee Appeal 545 (direct_review) ──── │ ID │ STATUS │ ASGN_BY │ ASGN_TO │ UPDATED_AT │ └── RootTask │ 1458 │ on_hold │ │ Bva │ 2020-05-22 14:47:39 UTC │ ├── DistributionTask │ 1459 │ completed │ │ Bva │ 2020-05-22 14:47:39 UTC │ ├── JudgeAssignTask │ 1460 │ completed │ │ BVAAABSHIRE │ 2020-06-01 14:34:38 UTC │ ├── JudgeDecisionReviewTask │ 2493 │ cancelled │ BVAAABSHIRE │ BVAAABSHIRE │ 2020-06-01 14:52:39 UTC │ │ └── AttorneyTask │ 2494 │ cancelled │ BVAAABSHIRE │ BVAEERDMAN │ 2020-06-01 14:52:39 UTC │ ├── JudgeAssignTask │ 2495 │ cancelled │ │ BVAAABSHIRE │ 2020-06-01 14:53:15 UTC │ ├── JudgeAssignTask │ 2496 │ completed │ BVAAABSHIRE │ BVAAABSHIRE │ 2020-06-01 18:17:36 UTC │ └── JudgeDecisionReviewTask │ 2523 │ on_hold │ BVARDUNKLE │ BVAAABSHIRE │ 2020-06-01 18:17:36 UTC │ └── AttorneyTask │ 2524 │ assigned │ BVARDUNKLE │ BVAEERDMAN │ 2020-06-01 18:17:36 UTC │ => nil task.cancelled! ``` 1. Ensure this does not close the judge review task and does not open a judge assign task ```ruby task.appeal.reload.treee Appeal 545 (direct_review) ID STATUS ASGN_BY ASGN_TO UPDATED_AT └── RootTask 1458 on_hold Bva 2020-05-22 14:47:39 UTC ├── DistributionTask 1459 completed Bva 2020-05-22 14:47:39 UTC ├── JudgeAssignTask 1460 completed BVAAABSHIRE 2020-06-01 14:34:38 UTC ├── JudgeDecisionReviewTask 2493 cancelled BVAAABSHIRE BVAAABSHIRE 2020-06-01 14:52:39 UTC │ └── AttorneyTask 2494 cancelled BVAAABSHIRE BVAEERDMAN 2020-06-01 14:52:39 UTC ├── JudgeAssignTask 2495 cancelled BVAAABSHIRE 2020-06-01 14:53:15 UTC ├── JudgeAssignTask 2496 completed BVAAABSHIRE BVAAABSHIRE 2020-06-01 18:17:36 UTC └── JudgeDecisionReviewTask 2523 assigned BVARDUNKLE BVAAABSHIRE 2020-06-02 19:45:16 UTC └── AttorneyTask 2524 cancelled BVARDUNKLE BVAEERDMAN 2020-06-02 19:45:16 UTC ``` ### User Facing Changes - [ ] None

Remove overtime status on judge or attorney reassignment

3cb011e

hschallhorn self-assigned this Jun 2, 2020

hschallhorn changed the base branch from master to hschallhorn/14225-proper-reassign-of-attorney-tasks June 2, 2020 20:41

Merge branch 'hschallhorn/14225-proper-reassign-of-attorney-tasks' in…

43ee4ec

…to hschallhorn/14366-remove-ot-on-reassignment

This was referenced Jun 3, 2020

[PART 1] Remove attorney task cancellation hook #14448

Merged

[PART 2] Perform "caseflow" reassign of attorney tasks #14452

Merged

hschallhorn added 3 commits June 3, 2020 14:05

Wip

f0d51c9

Properly set overtime to false when reassigning

970be15

Undo changes

9d63a8a

lint

b0172b4

hschallhorn requested a review from ajspotts June 4, 2020 13:49

hschallhorn changed the title ~~Remove overtime status of appeal if case is reassigned~~ [PART 3] Remove overtime status of appeal if case is reassigned Jun 4, 2020

hschallhorn commented Jun 4, 2020

View reviewed changes

Clear suvccess messages

1c612ce

hschallhorn commented Jun 9, 2020

View reviewed changes

ajspotts approved these changes Jun 9, 2020

View reviewed changes

hschallhorn merged commit 06bcb47 into hschallhorn/14225-proper-reassign-of-attorney-tasks Jun 9, 2020

hschallhorn deleted the hschallhorn/14366-remove-ot-on-reassignment branch June 9, 2020 16:18

hschallhorn mentioned this pull request Jun 9, 2020

Clear success messages in Mark Cases as OT modal #14493

Closed

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PART 3] Remove overtime status of appeal if case is reassigned #14453

[PART 3] Remove overtime status of appeal if case is reassigned #14453

hschallhorn commented Jun 2, 2020 •

edited by ajspotts

Loading

codeclimate bot commented Jun 2, 2020

va-bot commented Jun 3, 2020 •

edited

Loading

hschallhorn Jun 4, 2020

hschallhorn Jun 4, 2020

hschallhorn Jun 4, 2020

hschallhorn Jun 4, 2020

hschallhorn Jun 9, 2020

hschallhorn Jun 9, 2020

ajspotts left a comment

[PART 3] Remove overtime status of appeal if case is reassigned #14453

[PART 3] Remove overtime status of appeal if case is reassigned #14453

Conversation

hschallhorn commented Jun 2, 2020 • edited by ajspotts Loading

Description

Acceptance Criteria

Testing Plan

AMA Judge

AMA Attorney

Legacy Judge

User Facing Changes

codeclimate bot commented Jun 2, 2020

va-bot commented Jun 3, 2020 • edited Loading

hschallhorn Jun 4, 2020

Choose a reason for hiding this comment

hschallhorn Jun 4, 2020

Choose a reason for hiding this comment

hschallhorn Jun 4, 2020

Choose a reason for hiding this comment

hschallhorn Jun 4, 2020

Choose a reason for hiding this comment

hschallhorn Jun 9, 2020

Choose a reason for hiding this comment

hschallhorn Jun 9, 2020

Choose a reason for hiding this comment

ajspotts left a comment

Choose a reason for hiding this comment

hschallhorn commented Jun 2, 2020 •

edited by ajspotts

Loading

va-bot commented Jun 3, 2020 •

edited

Loading