Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deploy rails 5.1 to staging #2998

Merged
merged 2 commits into from Apr 25, 2019
Merged

deploy rails 5.1 to staging #2998

merged 2 commits into from Apr 25, 2019

Conversation

lihanli
Copy link
Contributor

@lihanli lihanli commented Apr 24, 2019 •
edited

Description of change

deploy rails 5.1 to staging

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@lihanli lihanli requested review from kfrz and kreek April 24, 2019 23:42
kfrz
kfrz approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@kfrz kfrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! 🚢 👍

@lihanli lihanli merged commit d4633f6 into master Apr 25, 2019
@lihanli lihanli deleted the rails-staging branch April 25, 2019 19:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kfrz kfrz kfrz approved these changes

@kreek kreek Awaiting requested review from kreek

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lihanli @kfrz @va-vfs-bot