Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Rack gem #3796

Merged
merged 4 commits into from
Jan 16, 2020
Merged

Update Rack gem #3796

merged 4 commits into from
Jan 16, 2020

Conversation

jholton
Copy link
Contributor

@jholton jholton commented Jan 16, 2020

Description of change

When trying to load the Sidekiq Web management page the following error occurs:

undefined method 'transform_keys' for #<ActionDispatch::Request::Session:0x00007f8fa6d3bcc

In this PR we update the Rack gem to reference a specific Github commit to fix a bug while we wait for a gem release.

More bug details can be found here:
rack/rack#1428

Testing done

specs

Testing planned

Acceptance Criteria (Definition of Done)

  • Rack bug is resolved. SIdekiq admin loads.

Unique to this PR

  • Update Rack gem

Applies to all PRs

  • Appropriate logging
  • Swagger docs have been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

@jholton jholton requested review from a team as code owners January 16, 2020 18:29
@jholton
Copy link
Contributor Author

jholton commented Jan 16, 2020

There is nothing in the Rack CHANGELOG that indicates any other changes that we need to worry about. Granted the CHANGELOG might not be complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants