Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

When a SubmitForm526 Job Fails, Try a Different BIRLS ID #5245

Merged
merged 44 commits into from
Mar 17, 2021
Merged

When a SubmitForm526 Job Fails, Try a Different BIRLS ID #5245

merged 44 commits into from
Mar 17, 2021

Conversation

edmangimelli
Copy link
Contributor

@edmangimelli edmangimelli commented Nov 7, 2020 •
edited

resolves #5268

(i talk a bit about the implementation in the issue ^^^)

@edmangimelli edmangimelli requested review from a team as code owners November 7, 2020 16:33
@edmangimelli edmangimelli self-assigned this Nov 7, 2020
@edmangimelli edmangimelli marked this pull request as draft November 9, 2020 06:09
@edmangimelli edmangimelli mentioned this pull request Nov 11, 2020
Closed
@edmangimelli edmangimelli marked this pull request as ready for review November 11, 2020 14:14
@annaswims annaswims marked this pull request as draft November 24, 2020 15:12
@annaswims
Copy link
Contributor

I'm wondering if we might be able to simplify this a lot if we stored all the potential bilrs id's when we create Form526Submission

@edmangimelli edmangimelli mentioned this pull request Jan 13, 2021
Closed
1 task
@edmangimelli edmangimelli changed the title [DRAFT] When a SubmitForm526 Job Fails, Try a Different BIRLS ID ❌ When a SubmitForm526 Job Fails, Try a Different BIRLS ID Feb 12, 2021
@edmangimelli edmangimelli mentioned this pull request Feb 12, 2021
Merged
1 task
@edmangimelli edmangimelli mentioned this pull request Feb 12, 2021
Merged
1 task
@edmangimelli edmangimelli changed the base branch from master to add-birls-ids-tried-methods-to-form526-submission--edm February 23, 2021 17:09
@edmangimelli edmangimelli changed the base branch from add-birls-ids-tried-methods-to-form526-submission--edm to master February 23, 2021 17:24
@edmangimelli edmangimelli marked this pull request as ready for review March 8, 2021 07:16
@edmangimelli edmangimelli changed the title ❌ When a SubmitForm526 Job Fails, Try a Different BIRLS ID When a SubmitForm526 Job Fails, Try a Different BIRLS ID Mar 8, 2021
@LindseySaari
Copy link
Contributor

Looks good.. but looks to be an issue with an existing cassette

@edmangimelli edmangimelli merged commit c7a0487 into master Mar 17, 2021
@edmangimelli edmangimelli deleted the handle-submission-when-there-are-multiple-active-birls-ids--edm branch March 17, 2021 16:22
This was referenced Mar 22, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LindseySaari LindseySaari LindseySaari approved these changes

@ericboehs ericboehs Awaiting requested review from ericboehs

@annaswims annaswims Awaiting requested review from annaswims

Assignees

@edmangimelli edmangimelli

Labels
VSA VSA Contract
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry SubmitForm526 Jobs When They Have Multiple BIRLS IDs
4 participants
@edmangimelli @annaswims @LindseySaari @va-vfs-bot