Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update json schema #803

Merged
merged 4 commits into from
Feb 21, 2017
Merged

Update json schema #803

merged 4 commits into from
Feb 21, 2017

Conversation

markolson
Copy link
Contributor

No description provided.

jbalboni
jbalboni approved these changes Feb 21, 2017
View reviewed changes
Copy link
Contributor

@jbalboni jbalboni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though I'm not sure what all of the changes mean.

@markolson
Copy link
Contributor Author

@jbalboni when the schema changed, I had to update the tests. Then, the output of "STARTUPDATE EFT" in the spool file didn't look good, so I added something to make it more humane.

@markolson markolson merged commit eac92a2 into master Feb 21, 2017
@markolson markolson deleted the update-json-schema branch February 21, 2017 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbalboni jbalboni jbalboni approved these changes

@lihanli lihanli lihanli approved these changes

Assignees
No one assigned
Labels
ed benefits rainbows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@markolson @jbalboni @lihanli @va-bot