Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes vaOnlineSchedulingStatusImprovement feature flag from past ap… #28336

Conversation

ryanshaw
Copy link
Contributor

@ryanshaw ryanshaw commented Mar 5, 2024

Note: This is part of a series of smaller PRs that breaks up the original large PR into more logical and reviewable chunks.

Summary

This removes the use of the va_online_scheduling_status_improvement feature flag from the src/applications/vaos/appointment-list/components/PastAppointmentsList/PastAppointmentsDateDropdown.jsx component within VA online scheduling. It is part of a set of PR's to address department-of-veterans-affairs/va.gov-team#55085. We no longer use this feature flag, so code behind this flag can be removed.

Related issue(s)

department-of-veterans-affairs/va.gov-team#55085

Testing done

  • Unit testing
  • e2e testing
  • Manual local testing

Acceptance criteria

Quality Assurance & Testing

  • I updated unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

…pointments date dropdown

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
@ryanshaw ryanshaw self-assigned this Mar 5, 2024
@ryanshaw ryanshaw marked this pull request as ready for review March 5, 2024 14:17
@ryanshaw ryanshaw requested review from a team as code owners March 5, 2024 14:17
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/55085/removes-feature-status-improvement-flag-from-past-appointment-list-dropdown/main March 5, 2024 14:18 Inactive
@ryanshaw ryanshaw marked this pull request as draft March 5, 2024 14:40
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Copy link
Contributor

@jenniemc jenniemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanshaw ryanshaw merged commit e17ec24 into main Mar 5, 2024
84 checks passed
@ryanshaw ryanshaw deleted the ryanshaw/55085/removes-feature-status-improvement-flag-from-past-appointment-list-dropdown branch March 5, 2024 19:34
pjhill pushed a commit that referenced this pull request Mar 14, 2024
#28336)

* Removes vaOnlineSchedulingStatusImprovement feature flag from past appointments date dropdown

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

* Updates unit test

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

---------

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants