New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[55085] Removes appointment list use of va online scheduling status improvement flag #27685

Closed

ryanshaw wants to merge 26 commits into main from ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag

Contributor

ryanshaw commented Jan 26, 2024

Summary

This removes the use of the va_online_scheduling_status_improvement feature flag from the /src/applications/vaos/appointment-list component and child components within VA online scheduling. It is part of a set of PR's to address department-of-veterans-affairs/va.gov-team#55085

Related issue(s)

department-of-veterans-affairs/va.gov-team#55085

Testing done

Unit testing
e2e testing

Acceptance criteria

Quality Assurance & Testing

I fixed|updated|added unit tests and integration tests for each feature (if applicable).
No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
Linting warnings have been addressed

Error Handling

Browser console contains no warnings or errors.
Events are being sent to the appropriate logging solution
Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

Did you login to a local build and verify all authenticated routes work as expected with a test user

ryanshaw added 3 commits

January 25, 2024 17:02


          Fixes linting error

07e368b

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>


          Removes feature status improvement feature flag and conditionals from…

dd52cd7

… appointment list components

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>


          WIP: skip unit tests

775c41b

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

ryanshaw self-assigned this

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

January 26, 2024 01:24

Inactive

ryanshaw added 2 commits

January 25, 2024 17:28


          WIP: enable test

bbb0a30


          WIP: disable test

a32b101

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

January 26, 2024 03:40

Inactive

ryanshaw added 2 commits

January 25, 2024 19:40


          WIP: test auto push

3645f01

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>


          WIP: disable test

e0ef1d5

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

January 26, 2024 03:45

Inactive


          Linting fixes

f0ada2a

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

January 26, 2024 15:19

Inactive

ryanshaw added 6 commits

January 28, 2024 17:58


          Fixes linting

aeb51e9

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

Revert "WIP: skip unit tests"

This reverts commit 775c41b.

Revert "WIP: enable test"

This reverts commit bbb0a30.

Revert "WIP: disable test"

This reverts commit a32b101.

Revert "WIP: test auto push"

This reverts commit 3645f01.

Revert "WIP: disable test"

This reverts commit e0ef1d5.


          Merge branch 'main' of github.com:department-of-veterans-affairs/vets…

db8da91

…-website into ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag


          Adds phone appointment to local mocks

db18888

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>


          Removes status improvement flag conditional blocks from appointment list

558b0f4

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>


          Updates comments

21ae339

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>


          WIP: skip tests

51351b7

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

January 29, 2024 15:56

Inactive

ryanshaw added 2 commits

February 5, 2024 08:06


          Removes unused unit test

48468ef

This test was removed because it was used for coverage of the pulldown on the appointment list page which was removed after the vaOnlineSchedulingStatusImprovement feature flag was enabled for all production users

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>


          Updates unit test

275b722

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 5, 2024 16:11

Inactive


          Updates unit tests

482041f

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 5, 2024 16:51

Inactive


          Merge branch 'main' of github.com:department-of-veterans-affairs/vets…

51367fa

…-website into ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 5, 2024 17:11

Inactive


          Fixes linting errors

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 6, 2024 01:13

Inactive


          Updates subPageTitle logic on appointments page

f7ef82c

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 6, 2024 03:20

Inactive


          Merge branch 'main' of github.com:department-of-veterans-affairs/vets…

3cfc2a7

…-website into ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 7, 2024 01:19

Inactive


          Merge branch 'main' of github.com:department-of-veterans-affairs/vets…

38b0146

…-website into ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 8, 2024 19:19

Inactive


          Merge branch 'main' of github.com:department-of-veterans-affairs/vets…

00e4219

…-website into ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 11, 2024 15:06

Inactive


          Updates comment

2b61e5f

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>

va-vfs-bot temporarily deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 12, 2024 17:02

Inactive


          Merge branch 'main' of github.com:department-of-veterans-affairs/vets…

…-website into ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag

va-vfs-bot deployed to master/ryanshaw/55085-removes-appointment-list-use-of-va_online_scheduling_status_improvement-flag/main

February 12, 2024 18:12

View deployment

ryanshaw marked this pull request as ready for review

February 12, 2024 18:43

ryanshaw requested review from a team as code owners

February 12, 2024 18:43

ryanshaw requested review from vbahinwillit, simiadebowale and jenniemc

February 12, 2024 18:43

va-vfs-bot reviewed

View reviewed changes

va-vfs-bot left a comment

ESLint is disabled

vets-website uses ESLint to help enforce code quality. In most situations we would like ESLint to remain enabled.

What you can do

See if the code can be refactored to avoid disabling ESLint, or wait for a VSP review.

src/applications/vaos/appointment-list/components/AppointmentListNavigation.jsx

+                            to="/"
+                            onClick={() => callback(true)}
+                            aria-current={
+                              Boolean(isUpcoming).toString() // eslint-disable-next-line jsx-a11y/aria-proptypes

va-vfs-bot Feb 12, 2024

ESLint disabled here

src/applications/vaos/appointment-list/components/AppointmentListNavigation.jsx

+                              });
+                            }}
+                            aria-current={
+                              Boolean(isPending).toString() // eslint-disable-next-line jsx-a11y/aria-proptypes

va-vfs-bot Feb 12, 2024

ESLint disabled here

src/applications/vaos/appointment-list/components/AppointmentListNavigation.jsx

+                              });
+                            }}
+                            aria-current={
+                              Boolean(isPast).toString() // eslint-disable-next-line jsx-a11y/aria-proptypes

va-vfs-bot Feb 12, 2024

ESLint disabled here

micahchiang reviewed

View reviewed changes

Contributor

micahchiang left a comment

This is a pretty large pull request. Is there any way this can be broken down into smaller more manageable submissions? If not, then can you provide a broader explanation of how this was tested beyond unit tests and e2e tests? Was this application run locally in browser to verify it functions as expected?

ryanshaw commented

View reviewed changes

Contributor Author

ryanshaw left a comment •

edited

This is a pretty large pull request. Is there any way this can be broken down into smaller more manageable submissions? If not, then can you provide a broader explanation of how this was tested beyond unit tests and e2e tests? Was this application run locally in browser to verify it functions as expected?

@micahchiang We don't currently use this feature flag, this removes a lot of conditional code that is no longer used. It has been broken down by higher level directories within the appointments application but I can break it down further. As for testing, manual spot checking of common user flows was done locally.

This was referenced Feb 15, 2024

55085 - removes vaOnlineSchedulingStatusImprovement flag from AppointmentsPage component #27996

Closed

55085 - removes vaOnlineSchedulingStatusImprovement flag from AppointmentsPage component #28008

Closed

Contributor Author

ryanshaw commented Feb 16, 2024

Closing this PR and addressing the issue with a set of smaller PRs, here's the first one: #28008

ryanshaw closed this

This was referenced Feb 16, 2024

55085 - removes vaOnlineSchedulingStatusImprovement flag from AppointmentsPage component #28033

Merged

Removes vaOnlineSchedulingStatusImprovement feature flag code from ApointmentListNavigation component #28047

Merged

Removes vaOnlineSchedulingStatusImprovement from ScheduleNewAppointment component #28048

Merged

This was referenced Mar 5, 2024

Removes vaOnlineSchedulingStatusImprovement feature flag from past ap… #28336

Merged

Removes vaOnlineSchedulingStatusImprovement feature flag from requested appointments list #28337

Merged

Removes vaOnlineSchedulingStatusImprovement from unit tests #28339

Draft

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

micahchiang micahchiang left review comments

va-vfs-bot va-vfs-bot left review comments

vbahinwillit Awaiting requested review from vbahinwillit vbahinwillit is a code owner automatically assigned from department-of-veterans-affairs/vfs-vaos-fe

simiadebowale Awaiting requested review from simiadebowale simiadebowale is a code owner automatically assigned from department-of-veterans-affairs/vfs-vaos-fe

jenniemc Awaiting requested review from jenniemc jenniemc is a code owner automatically assigned from department-of-veterans-affairs/vfs-vaos-fe