Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes vaOnlineSchedulingStatusImprovement from unit tests #28339

Draft
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

ryanshaw
Copy link
Contributor

@ryanshaw ryanshaw commented Mar 5, 2024

Note: This is part of a series of smaller PRs that breaks up the original large PR into more logical and reviewable chunks.

Summary

This removes the use of the unit tests within VA online scheduling. It is part of a set of PR's to address department-of-veterans-affairs/va.gov-team#55085. We no longer use this feature flag, so code behind this flag can be removed.

Related issue(s)

department-of-veterans-affairs/va.gov-team#55085

Testing done

  • Unit testing
  • e2e testing
  • Manual local testing

Acceptance criteria

Quality Assurance & Testing

  • I updated unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
@ryanshaw ryanshaw self-assigned this Mar 5, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests/main March 5, 2024 14:42 Inactive
…-website into ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests
…unit test

Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests/main March 5, 2024 20:20 Inactive
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests/main March 5, 2024 21:04 Inactive
…-website into ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests/main March 6, 2024 02:54 Inactive
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
@va-vfs-bot va-vfs-bot temporarily deployed to master/ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests/main March 6, 2024 02:59 Inactive
…-website into ryanshaw/55085/removes-feature-status-improvement-flag-from-appointments-unit-tests
Signed-off-by: Ryan Shaw <ryan.shaw@adhocteam.us>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants