Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CST] Remove unused CSS classes #29440

Merged
merged 2 commits into from
Apr 26, 2024
Merged

[CST] Remove unused CSS classes #29440

merged 2 commits into from
Apr 26, 2024

Conversation

jerekshoe
Copy link
Contributor

@jerekshoe jerekshoe commented Apr 26, 2024

Summary

Removing unused CSS classes from claims-status.scss that were updated in this PR

Related issue(s)

Screenshots

.claim-list-item-container .claim-list-item-container
.claim-list-item-header-old .claim-list-item-header-old
.claim-list-item-header-v2 .claim-list-item-header-v2
.event-date .event-date
.event-header .event-header
.event-header-icon .event-header-icon
.event-title .event-title
.event-description .event-description
.claims-first-paragraph .claims-first-paragraph
.loading-message-center-spinner .loading-message-center-spinner
.usa-input-error .usa-input-error
.claims-list-sort* .claims-list-sort*
.claims-breadcrumbs .claims-breadcrumbs

What areas of the site does it impact?

Claim Status Tool

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

(OPTIONAL) What should the reviewers know in addition to the above. Is there anything specific you wish the reviewer to assist with. Do you have any concerns with this PR, why?

@jerekshoe jerekshoe self-assigned this Apr 26, 2024
@va-vfs-bot va-vfs-bot temporarily deployed to master/81718-remove-unused-css/main April 26, 2024 15:42 Inactive
Copy link
Contributor

@samcoforma samcoforma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jerekshoe thanks for including those search result screenshots, made this easier

@jerekshoe jerekshoe merged commit 1876f6f into main Apr 26, 2024
87 checks passed
@jerekshoe jerekshoe deleted the 81718-remove-unused-css branch April 26, 2024 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants