Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MHV Landing page & Secondary Nav changes for formation font-size updates #29750

Merged
merged 1 commit into from
May 14, 2024
Merged

MHV Landing page & Secondary Nav changes for formation font-size updates #29750

merged 1 commit into from
May 14, 2024

Conversation

dcloud
Copy link
Contributor

@dcloud dcloud commented May 13, 2024

Summary

  • 10px * 0.4rem -> 16px * 0.25rem

Related issue(s)

Testing done

  • Visual diff of before/after using Difference filter in image editor to look for pixel differences

Check out 66753-formation-global-overrides in vets-website, 66753-formation-typography-updates in content-build, yarn install to make sure we are building against content-build. Screenshot before and after, then do an image diff in your favorite image editor

Screenshots

Note: This field is mandatory for UI changes (non-component work should NOT have screenshots).

Before After
Mobile
Desktop Screen Shot 2024-05-13 at 15 30 02 Screen Shot 2024-05-13 at 15 44 17

What areas of the site does it impact?

MHV Secondary Nav

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

@dcloud dcloud mentioned this pull request May 13, 2024
Merged
13 tasks
@dcloud dcloud changed the title Tweak padding values for 10->16px base font-size change MHV Landing page & Secondary Nav changes for formation font-size updates May 13, 2024
@dcloud dcloud marked this pull request as ready for review May 14, 2024 14:05
@dcloud dcloud requested review from a team as code owners May 14, 2024 14:05
@dcloud dcloud merged commit 117ecb7 into 66753-formation-global-overrides May 14, 2024
65 of 85 checks passed
@dcloud dcloud deleted the dcloud/66753-formation-mhv-secondary-nav branch May 14, 2024 14:12
powellkerry added a commit that referenced this pull request May 20, 2024
@jamigibbs @micahchiang
@harshil1793 @powellkerry @nickjg231 @jerekshoe @Andrew565 @rmessina1010 @it-harrison @dcloud @aubreyarcangel @gerard-sullivan @robertbylight @Mottie @mattwrightva @wright0776
Formation Global Updates: Base font-size change from 10px to 16px (#2…
80ad96a 
…6606)

* add override stylesheets for uswds imports

* update nav spacing, add rem conversion function

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* fix megamenu level 1 links

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* fix: removed deprecated imported and formation update

* Fix crisis line button alignment, search button vertical alignment, and facility locator search button width

* Fix sign in modal issues caused by typography size changes

* Fix icon size and modal width issues caused by base font-size change

* Fix subheader font size and margin bottom due to base font-size change

* Update rem values in scss files affected by global font size

* update: formation package to v11.0.0

* cypress facility search element width fix

* adjust facility-locator test

* fix: padding for facility search box

* fix scss error due to merge syntax

* fix: search button width correction

* convert rem values in facility locator for failed test

* attempt to fix facility-locator test

* attempt to fix facility-locator test

* attempt to fix facility-locator test

* convert rem values to be based on 16px base font-size instead of 10px (#29407)

* update component-library and web-components versions

* 2702-rem conversion for burials-v2 and caregivers

* Appeals 995 & 996: Update `rem` value for 16px base font size (#29410)

* update rem to 16px base font

* remove breaking font-size style

* 2703-rem conversion for check-in and claims-status

* convert rem for appeals/10182 and appeals/shared

* convert rem for edu/5490 and edu/10203

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* update rem values for health-care-supply-reordering and letters

* convert rem for edu/sass/edu-benefits

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* convert rem for discharge-wizard and education-letters

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* 2713 - update rem values for mhv, mhv-medical-records, and mhv-secure-messaging

* convert rem for fry-dea and gi

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* 2714 - update rem values for my-education-benefits and pre-need

* update rem to 16px base font (#29432)

* update rem values for disability-benefits/all-claims (#29439)

* convert rem for ask-va and ask-a-question

* convert rem for enrollment-verification

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* convert rem for fsr and find forms

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* convert rem for auth

* Updating rems for 20-10206 and 20-10207 (#29442)

* Updating rem values to account for 16px font size for dhp-connected-devices and discharge-wizard (#29418)

* Updating 26-4555

* convert rem values in /src/platform

* Updating simple-forms/mock-simple-forms-patterns-v3

* updating simple-forms/40-0247

* Updating simple-forms/shared

* remove unused formation-override-function

* 2724 - rem conversion for vaos and verify-your-enrollment

* remove unused import

* add missing semicolons

* 2719-converts search and representative-search

* update rem for disability-benefits/2346

* update rem for disability-benefits/686c-674

* logging for CI debugging

* update logging

* update rem for personalization/dashboard

* revert ci logging

* update rem for personalization/profile

* update rem values in simple-forms & profile

* update web-components pacakge to 8.0.0-beta.1 and component-library to 41.0.0-beta.0

* update rem for personalization/view-dependents

* update rem for pre-need-integration

* Updating rems for 21-0845 and 21-10210 (#29443)

* update rem for proxy-rewrite

* update rem for public-outreach-materials

* Fix failing unit test

* fix schemaform-subtitle rev value

* changes for 2730 - typography of injected header/footer

* fix accessiblity issue with e2e test

* bump "Run Cypress tests" timout to 180

* update formation version with units fix

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* update check in rem

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* update component-library version

* fix submit button size

* revert icon changes

* update mhv-landing-page

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* remove commented code, update unit test comment

* update shame.scss

* Update InformalConference.unit.spec.jsx to fix failing test

* changes to fix injected teamsite header issues

* Update to override foundation-sites npm package rem values

* MHV  Secondary Nav: Tweak padding values for 10->16px base font-size change (#29750)

* [MHV 55425] did a git-move and rename (#29789)

* DR | Downtime updates & testing (#29755)

* Fix save-in-progress alert title

* Fix downtime alert headers

* Add & update unit tests

* Add appeals downtime e2e tests

* Add missing formConfig

* Add customText to facility locator

* inject axe before check

* Update check-in appType

* MHV-58050: Chem/hem content updates (#29698)

* MHV-58050: Chem/hem content updates

* MHV-58050: UCD validation feedback updates

* MHV-58050: Unit tests written

* MHV-58050: Cypress test fixed

---------

Co-authored-by: Matthew Wright <matwright2010@gmail.com>

* medallia style updates

* update component-library and css-library version

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>

* revert changes to unit test

* regnerate yarn.lock file

* update yarn.lock

* Fix header max-width in proxy-rewrite

---------

Signed-off-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: Micah Chiang <micahkchiang@gmail.com>
Co-authored-by: harshil1793 <harshil1793@gmail.com>
Co-authored-by: Kerry Powell <kerry.powell@adhocteam.us>
Co-authored-by: nickgaydosh <nickgaydosh@gmail.com>
Co-authored-by: Kerry Powell <kerry.powell@va.gov>
Co-authored-by: jerekshoe <jerek.shoemaker@adhocteam.us>
Co-authored-by: Harshil <harshil.moradia@adhoc.team>
Co-authored-by: Andrew Steele <andrew.steele@adhocteam.us>
Co-authored-by: Ray Messina <rmessina10@gmail.com>
Co-authored-by: Ian <harrison.ian.t@gmail.com>
Co-authored-by: Daniel Cloud <daniel.cloud@va.gov>
Co-authored-by: aubreyarcangel <aarcangel@gmail.com>
Co-authored-by: gerard-sullivan <132001256+gerard-sullivan@users.noreply.github.com>
Co-authored-by: robertbylight <107279507+robertbylight@users.noreply.github.com>
Co-authored-by: Rob Garrison <wowmotty@gmail.com>
Co-authored-by: mattwrightva <107576133+mattwrightva@users.noreply.github.com>
Co-authored-by: Matthew Wright <matwright2010@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@powellkerry powellkerry powellkerry approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dcloud @powellkerry @va-vfs-bot