Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

86842c Small copy changes (round 3) - form 10-7959a #30848

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

michaelclement
Copy link
Contributor

Are you removing, renaming or moving a folder in this PR?

  • No, I'm not changing any folders (skip to Summary and delete the rest of this section)
  • Yes, I'm removing, renaming or moving a folder

Summary

Adjusts copy in beneficiary section of form 10-7959a

  • Updates text "the beneficiary" to "your" on the /beneficiary-identification-info screen hint
  • Updates "information" to "name" on the /beneficiary-info screen
  • Team: IVC CHAMPVA
  • Flipper: NA

Related issue(s)

Testing done

  • Manual

Screenshots

1 2
Desktop Screenshot 2024-07-16 at 07 49 35 Screenshot 2024-07-16 at 07 57 54

What areas of the site does it impact?

This form only

Acceptance criteria

Quality Assurance & Testing

  • I fixed|updated|added unit tests and integration tests for each feature (if applicable).
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs
  • Linting warnings have been addressed
  • Documentation has been updated (link to documentation *if necessary)
  • Screenshot of the developed feature is added
  • Accessibility testing has been performed

Error Handling

  • Browser console contains no warnings or errors.
  • Events are being sent to the appropriate logging solution
  • Feature/bug has a monitor built into Datadog or Grafana (if applicable)

Authentication

  • Did you login to a local build and verify all authenticated routes work as expected with a test user

⚠️ Team Sites (only applies to modifications made to the VA.gov header) ⚠️

  • The vets-website header does not contain any web-components
  • I used the proxy-rewrite steps to test the injected header scenario
  • I reached out in the #sitewide-public-websites Slack channel for questions

Requested Feedback

NA

@michaelclement michaelclement marked this pull request as ready for review July 16, 2024 13:31
@michaelclement michaelclement requested a review from a team as a code owner July 16, 2024 13:31
Copy link
Contributor

@IGallupSoCo IGallupSoCo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelclement michaelclement merged commit 8879c32 into main Jul 16, 2024
75 checks passed
@michaelclement michaelclement deleted the 86842c-small-copy-changes branch July 16, 2024 18:56
DLarson-Oddball pushed a commit that referenced this pull request Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants