Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

heroku github auth #8207

Merged
merged 9 commits into from
Aug 19, 2018
Merged

heroku github auth #8207

merged 9 commits into from
Aug 19, 2018

Conversation

wyattwalter
Copy link
Contributor

@wyattwalter wyattwalter commented Aug 17, 2018

Description

Provides authentication to API call back to GitHub from the Heroku review application build process. Auth isn't necessary to read the data we need (and the token has zero privileges), but helps us avoid rate-limiting.

Testing done

Only affects builds in Heroku, tested there

Unique to this PR

  • authenticates requests back to GitHub

Applies to all PRs

  • Appropriate logging
  • Documentation has been updated, if applicable
  • Provide link to originating GitHub issue, or connected to it via ZenHub
  • Does not contain any sensitive information (i.e. PII/credentials/internal URLs/etc., in logging, hardcoded, or in specs)
  • Provide which alerts would indicate a problem with this functionality (if applicable)

https://github.com/department-of-veterans-affairs/vets.gov-team/issues/12115

@wyattwalter wyattwalter changed the title Ww heroku gh auth heroku github auth Aug 17, 2018
@va-bot va-bot temporarily deployed to vetsgov-pr-8207 August 17, 2018 21:27 Inactive
@wyattwalter wyattwalter temporarily deployed to vetsgov-pr-8207 August 17, 2018 21:37 Inactive
@wyattwalter wyattwalter temporarily deployed to vetsgov-pr-8207 August 17, 2018 21:42 Inactive
Copy link
Contributor

@ncksllvn ncksllvn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants