[FacilityLocator] Prettier Linting Changes #9071
Conversation
* Removed the global disables from all files. * Left a few single-line disables as the "prettier" version was more unreadable. * Quick fix to API to support that Provider records also come back wrapped in a 'data' block * Restructured some Action logic to use async/await syntax * Other small changes as suggested in previous PR (#8651)
| * @param {Object} query The current state of the Search form | ||
| */ | ||
| // eslint-disable-next-line prettier/prettier |
There was a problem hiding this comment.
Why are these still disabled?
There was a problem hiding this comment.
Clarity. Not having the method's argument list inside parens makes it harder to see when using arrow function syntax. Using arrow functions shouldn't need to remove the basics of function arguments/parameters being inside parenthesis.
There was a problem hiding this comment.
Note that it still requires parens when there are more than one argument.
| @@ -1,4 +1,3 @@ | |||
| /* eslint-disable prettier/prettier */ | |||
| /* eslint-disable no-use-before-define */ | |||
There was a problem hiding this comment.
I don't think this should need to be disabled. Should be fixed if it's easy.
There was a problem hiding this comment.
This one is the linter not liking the order of declarations. renderPhoneNumber is a support function and below the SFC LocationPhoneLink, however, it is used a few times inside the main body of the SFC.
Fixing it would require the helper be moved up to the top of the file which would be confusing as this is the LocationPhoneLink component so that should be first.
It doesn't actually break the code or functionality of the component so I disabled it. (Near as I can tell this rule is only checking where in the file the function was declared and where it was used (i.e. line#). But no actual checks on whether or not it would actually cause a problem.)
* master: 526 empty supporting evidence mg (#9106) Move assets into /src/site/assets (#9138) Create src/site/stages (#9130) Move most of va-gov's contents to src/site (#9127) Remove the submit promise (#9140) turn on online only and distance learning (#9090) Bump formation version to fix headings (#9141) Add POW to specialIssues array (#9131) GIBS wizard (#9107) [FacilityLocator] Prettier Linting Changes (#9071)
Description
Follow up to previous FacilityLocator PR to do the 2nd pass for Prettier's syntax needs.
Acceptance criteria
(CC'ing reviewers for visibility @U-DON @bshyong )