Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ignore and remove downloaded assets #9527

Merged
merged 1 commit into from
Feb 6, 2019
Merged

Ignore and remove downloaded assets #9527

merged 1 commit into from
Feb 6, 2019

Conversation

jbalboni
Copy link
Contributor

@jbalboni jbalboni commented Feb 5, 2019 •
edited
Loading

Description

Sometimes eslint is running on downloaded assets in a temp directory. We should ignore that directory and also remove it after using it.

Testing done

Ran locally

Acceptance criteria

  • Temp directory is emptied

Definition of done

  • Events are logged appropriately
  • Documentation has been updated, if applicable
  • A link has been provided to the originating GitHub issue (or connected to it via ZenHub)
  • No sensitive information (i.e. PII/credentials/internal URLs/etc.) is captured in logging, hardcoded, or specs

@va-bot va-bot temporarily deployed to vetsgov-pr-9527 February 5, 2019 20:51 Inactive
@va-bot va-bot temporarily deployed to master/cleanup-downloaded-assets-jsb February 5, 2019 21:15 Inactive
@wyattwalter wyattwalter merged commit cbd2c10 into master Feb 6, 2019
@wyattwalter wyattwalter deleted the cleanup-downloaded-assets-jsb branch February 6, 2019 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyattwalter wyattwalter wyattwalter approved these changes

@cvalarida cvalarida Awaiting requested review from cvalarida

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jbalboni @wyattwalter @va-bot