Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better prettier configuration #490

Merged
merged 5 commits into from
Dec 29, 2019
Merged

Better prettier configuration #490

merged 5 commits into from
Dec 29, 2019

Conversation

znarf
Copy link
Collaborator

@znarf znarf commented Dec 29, 2019

  • add scripts to check the whole repository npm run prettier and npm run prettier-check
  • apply with npm run prettier -- --write
  • add .prettierignore
  • add pre-commit hook using husky and lint-staged
  • add check to CI to prevent formatting regressions

@codecov
Copy link

codecov bot commented Dec 29, 2019

Codecov Report

Merging #490 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #490   +/-   ##
=======================================
  Coverage   98.18%   98.18%           
=======================================
  Files          40       40           
  Lines         771      771           
=======================================
  Hits          757      757           
  Misses         14       14
Impacted Files Coverage Δ
src/cli.js 100% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7c21c...14ee96a. Read the comment docs.

@rumpl
Copy link
Member

rumpl commented Dec 29, 2019

Hey @znarf thank you for this, could we just remove the husky integration? I really am not a fan of pre-commit checks that take time, I want my git to be fast, checking this on the CI is ok, but not on my machine. We can add it later if we see that too many contributions from external people are failing because of the prettier check.

Cheers

@rumpl
Copy link
Member

rumpl commented Dec 29, 2019

Could you add the prettier check also to the appveyor and travis files?

We need less systems for our CI...

@znarf
Copy link
Collaborator Author

znarf commented Dec 29, 2019

@rumpl I personally have good experience with pre-commit hooks for prettier. I understand your concerns and will remove it.

Haven't noticed appveyor and travis yet, will look at it.

@rumpl rumpl merged commit bd1a268 into depcheck:master Dec 29, 2019
@rumpl
Copy link
Member

rumpl commented Dec 29, 2019

Thanks!

@znarf znarf deleted the better-prettier branch January 2, 2020 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants