Add eslint-plugin-mocha and lint test directory #492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome! #490 is merged, you can rebase now |
znarf
force-pushed
the
eslint-plugin-mocha
branch
from
c381a25
to
0259605
Compare
Codecov Report
@@ Coverage Diff @@
## master #492 +/- ##
=======================================
Coverage 98.18% 98.18%
=======================================
Files 40 40
Lines 771 771
=======================================
Hits 757 757
Misses 14 14Continue to review full report at Codecov.
|
|
@rumpl Thanks, rebased! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed some
globalsin the test files fordescribeandit. I'm proposing to addeslint-plugin-mochaas a cleaner alternative. We would later be able to useplugin:mocha/recommendedto implement good practices in test files.Also took the opportunity to enforce
lintin thetestdirectory. Added some extra folders to.eslintignorefor that reason.Note: CI is not expected to pass yet because of some
prettiererrors. They should be fixed in #490