Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hide more credentials from the updater #216

Merged
merged 1 commit into from
Jan 2, 2024
Merged

hide more credentials from the updater #216

merged 1 commit into from
Jan 2, 2024

Conversation

jakecoffman
Copy link
Member

Following #215, this prevents key and auth-key fields from getting into the updater when generating credentials-metadata.

Thanks for spotting this @mctofu.

@jakecoffman jakecoffman requested a review from a team as a code owner January 2, 2024 18:00
@jakecoffman jakecoffman added this pull request to the merge queue Jan 2, 2024
Merged via the queue into main with commit a104d64 Jan 2, 2024
60 checks passed
@jakecoffman jakecoffman deleted the jakecoffman/hide-more-credentials-from-updater branch January 2, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@honeyankit honeyankit honeyankit approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jakecoffman @honeyankit