Merge pull request #9206 from dependabot/jamiemagee/rubocop-rspec

Add and configure `rubocop-rspec`

.rubocop.yml

@@ -1,6 +1,7 @@
 ---
 require:
   - rubocop-performance
+  - rubocop-rspec
   - rubocop-sorbet
 
 AllCops:
@@ -341,6 +342,15 @@ Sorbet/StrictSigil:
 Sorbet/StrongSigil:
   Exclude:
     - "**/spec/**/*"
+RSpec:
+  Include:
+    - "**/spec/**/*"
+
+# TODO: Fix these and re-enable
+RSpec/FilePath:
+  Enabled: false
+RSpec/SpecFilePathFormat:
+  Enabled: false
 
 # TODO these were temporarily disabled during the Ruby 2.7 -> 3.1 upgrade
 # in order to keep the upgrade diff small, they will be enabled/fixed in

Gemfile

@@ -37,6 +37,7 @@ deps_shared_with_common = %w(
   rspec-sorbet
   rubocop
   rubocop-performance
+  rubocop-rspec
   rubocop-sorbet
   stackprof
   turbo_tests

Gemfile.lock

@@ -288,9 +288,17 @@ GEM
       unicode-display_width (>= 2.4.0, < 3.0)
     rubocop-ast (1.30.0)
       parser (>= 3.2.1.0)
+    rubocop-capybara (2.20.0)
+      rubocop (~> 1.41)
+    rubocop-factory_bot (2.25.1)
+      rubocop (~> 1.41)
     rubocop-performance (1.19.1)
       rubocop (>= 1.7.0, < 2.0)
       rubocop-ast (>= 0.4.0)
+    rubocop-rspec (2.27.1)
+      rubocop (~> 1.40)
+      rubocop-capybara (~> 2.17)
+      rubocop-factory_bot (~> 2.22)
     rubocop-sorbet (0.7.6)
       rubocop (>= 0.90.0)
     ruby-progressbar (1.13.0)
@@ -381,6 +389,7 @@ DEPENDENCIES
   rspec-sorbet (~> 1.9.2)
   rubocop (~> 1.58.0)
   rubocop-performance (~> 1.19.0)
+  rubocop-rspec (~> 2.27.1)
   rubocop-sorbet (~> 0.7.3)
   sorbet (= 0.5.11274)
   stackprof (~> 0.2.16)

common/dependabot-common.gemspec

@@ -52,6 +52,7 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rspec-sorbet", "~> 1.9.2"
   spec.add_development_dependency "rubocop", "~> 1.58.0"
   spec.add_development_dependency "rubocop-performance", "~> 1.19.0"
+  spec.add_development_dependency "rubocop-rspec", "~> 2.27.1"
   spec.add_development_dependency "rubocop-sorbet", "~> 0.7.3"
   spec.add_development_dependency "stackprof", "~> 0.2.16"
   spec.add_development_dependency "turbo_tests", "~> 2.2.0"