Add and configure rubocop-rspec
#9206
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JamieMagee
force-pushed
the
jamiemagee/rubocop-rspec
branch
2 times, most recently
from
fd46cc0
to
96fae57
Compare
JamieMagee
force-pushed
the
jamiemagee/rubocop-rspec
branch
2 times, most recently
from
1b1cc1f
to
85d134d
Compare
[`rubocop-rspec`][1] is a set of RuboCop rules for RSpec. This change adds a dependency on `rubocop-rspec` and configures it in our `.rubocop.yml`. 2 rules, `RSpec/FilePath` and `RSpec/SpecFilePathFormat`, were disabled to keep the diff small. They can be re-enabled later. Also, `rubocop-rspec` follows RuboCop's versioning, and newly introduced rules are not enabled by default. As you can see, the minor version is `27`, so there are quite a few rules that we should evaluate and explicitly enable. [1]: https://docs.rubocop.org/rubocop-rspec/index.html
JamieMagee
force-pushed
the
jamiemagee/rubocop-rspec
branch
from
85d134d
to
b16a865
Compare
bdragon
approved these changes
Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rubocop-rspecis a set of RuboCop rules for RSpec.This change adds a dependency on
rubocop-rspecand configures it in our.rubocop.yml.2 rules,
RSpec/FilePathandRSpec/SpecFilePathFormat, were disabled to keep the diff small.They can be re-enabled later.
Also,
rubocop-rspecfollows RuboCop's versioning, and newly introduced rules are not enabled by default.As you can see, the minor version is
27, so there are quite a few rules that we should evaluate and explicitly enable.