-
Notifications
You must be signed in to change notification settings - Fork 1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
A new version of RuboCop was released, and broke our CI. We generally want to proactively update RuboCop, and not have to react to it breaking our CI. So I'd rather keep the version we run locked. To keep it locked, we have to use the `updater/Gemfile`, since that's the one that includes a lockfile. To do that we configure `BUNDLE_GEMFILE` in CI to use that. I decided to also add a rubocop binstub to make it easier to run rubocop either outside (like CI does) or inside our development image.
- Loading branch information
1 parent
a4e8046
commit 494e669
Showing
3 changed files
with
14 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -14,4 +14,4 @@ shellcheck \ | |
./updater/bin/run \ | ||
"$@" | ||
|
||
bundle exec rubocop | ||
bin/rubocop |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,11 @@ | ||
#!/usr/bin/env ruby | ||
# frozen_string_literal: true | ||
|
||
updater_image_gemfile = File.expand_path("../dependabot-updater/Gemfile", __dir__) | ||
updater_repo_gemfile = File.expand_path("../updater/Gemfile", __dir__) | ||
|
||
ENV["BUNDLE_GEMFILE"] ||= File.exist?(updater_image_gemfile) ? updater_image_gemfile : updater_repo_gemfile | ||
|
||
require "bundler/setup" | ||
|
||
load Gem.bin_path("rubocop", "rubocop") |