Skip to content

Commit

Permalink
Remove manual exclusion of specific packages (#7676)
Browse files Browse the repository at this point in the history
The exclusion for these two packages was added years ago by Grey, back
when Dependabot ran on a completely different service back-end.

Since then, much of our internal infra has been completely rewritten
and any failures with deps in prod can invariably be repro'd locally, so
it no longer makes sense to carve out these exclusions.

I suspect the underlying issue in `composer` that led to this problem
has likely been fixed (at least in `composer 2`) so we won't see this
problem.

But if for some reason we do, than we should investigate further to see
what the _root_ problem is rather than swallowing it.
  • Loading branch information
jeffwidman committed Jul 31, 2023
1 parent 7cc9be1 commit 9d1973b
Showing 1 changed file with 0 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -325,13 +325,6 @@ def handle_composer_errors(error)
# dependency is no longer required and is just cruft in the
# composer.json. In this case we just ignore the dependency.
nil
elsif error.message.include?("stefandoorn/sitemap-plugin-1.0.0.0") ||
error.message.include?("simplethings/entity-audit-bundle-1.0.0")
# We get a recurring error when attempting to update these repos
# which doesn't recur locally and we can't figure out how to fix!
#
# Package is not installed: stefandoorn/sitemap-plugin-1.0.0.0
nil
elsif error.message.include?("does not match the expected JSON schema")
msg = "Composer failed to parse your composer.json as it does not match the expected JSON schema.\n" \
"Run `composer validate` to check your composer.json and composer.lock files.\n\n" \
Expand Down

0 comments on commit 9d1973b

Please sign in to comment.