Remove manual exclusion of specific packages #7676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The exclusion for these two packages was added years ago by Grey, back when Dependabot ran on a completely different service back-end. Since then, much of our internal infra has been completely rewritten and any failures with deps in prod can invariably be repro'd locally, so it no longer makes sense to carve out these exclusions. I suspect the underlying issue in `composer` that led to this problem has likely been fixed (at least in `composer 2`) so we won't see this problem. But if for some reason we do, than we should investigate further to see what the _root_ problem is rather than swallowing it.
deivid-rodriguez
approved these changes
Jul 31, 2023
abdulapopoola
approved these changes
Jul 31, 2023
brettfo
pushed a commit
to brettfo/dependabot-core
that referenced
this pull request
Oct 11, 2023
The exclusion for these two packages was added years ago by Grey, back when Dependabot ran on a completely different service back-end. Since then, much of our internal infra has been completely rewritten and any failures with deps in prod can invariably be repro'd locally, so it no longer makes sense to carve out these exclusions. I suspect the underlying issue in `composer` that led to this problem has likely been fixed (at least in `composer 2`) so we won't see this problem. But if for some reason we do, than we should investigate further to see what the _root_ problem is rather than swallowing it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The exclusion for these two packages was added years ago by Grey, back when Dependabot ran on a completely different service back-end.
Since then, much of our internal infra has been completely rewritten and any failures with deps in prod can invariably be repro'd locally, so it no longer makes sense to carve out these exclusions.
I suspect the underlying issue in
composerthat led to this problem has likely been fixed (at least incomposer 2) so we won't see this problem.But if for some reason we do, than we should investigate further to see what the root problem is rather than swallowing it.